Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 2.5.0 to 2.6.1. breaks #6134

Closed
heinemml opened this issue Sep 5, 2014 · 19 comments
Closed

Upgrade from 2.5.0 to 2.6.1. breaks #6134

heinemml opened this issue Sep 5, 2014 · 19 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@heinemml
Copy link

heinemml commented Sep 5, 2014

Hi,

I just upgraded from 2.5.0 to 2.6.1 via autoupdate.
Instantly after starting the upgrade I only get the following error on all pages:

"Fatal error: Constructor Piwik\Factory::factory() cannot be static in /var/www/piwik/htdocs/core/Factory.php on line 60"

I guess I need to re-install manually?

Edit: Ubuntu 10.04.4 LTS, PHP Version 5.3.2-1ubuntu4.26

@rroemhild
Copy link

Same for me. After a manuall re-install still the same error.

Ubuntu 10.04
PHP 5.3.2

@sgiehl sgiehl added the Bug label Sep 5, 2014
@sgiehl
Copy link
Member

sgiehl commented Sep 5, 2014

I guess that is an PHP 5.3.2 issue. The name of that method is named as the class, Before PHP 5.3.3 constructors could also have the name of the class.
@diosmosis You've added the Factory. I guess we need to rename that to make it work again on PHP 5.3.2

@sgiehl
Copy link
Member

sgiehl commented Sep 6, 2014

Thx @diosmosis for fixing
@mattab could you build a new release to fix piwik for PHP 5.3.2
Btw. Can't we let travis run the tests on 5.3.2 instead of 5.3.3 to avoid those issues?

@JeGr
Copy link

JeGr commented Sep 6, 2014

@sgiehl Is the mentioned fix meant for a release with Piwik 2.6.2? As it stands now, new installations or updates on old Ubuntu 10.04LTS machines will break with 2.6.1. Is that on route for another minor bugfix update?

@sgiehl
Copy link
Member

sgiehl commented Sep 6, 2014

That should also fix broken installations, but you might need to reupload manually. @mattab is the release manager, guess he will build piwik 2.6.2, as that is a major bug for PHP 5.3.2

@heinemml
Copy link
Author

heinemml commented Sep 6, 2014

Applied the Patch manually. Works for me now.

@mattab
Copy link
Member

mattab commented Sep 6, 2014

Btw. Can't we let travis run the tests on 5.3.2 instead of 5.3.3 to avoid those issues?

AFAIK travis only proposes php 5.3.2... Also we will likely increase requirements to 5.3.3 later when we work on DI #4917.

@mattab mattab added this to the Piwik 2.7.0 milestone Sep 6, 2014
@mattab mattab added the Major label Sep 6, 2014
@mawi22
Copy link

mawi22 commented Sep 6, 2014

Hi,

I am using 2.6.1 (manual installation) based on Ubuntu 10.04 and PHP 5.3.2.
The Error Log shows:

[Sat Sep 06 22:30:02 2014] [warn] [client IP-Adresse] mod_fcgid: stderr: PHP Fatal error: Constructor Piwik\Factory::factory() cannot be static in /var/www/vhosts/Domain/piwik/core/Factory.php on line 60

Further, there is always shown a white screen.

Any idea what went wrong and what to do to solve the prob?

Thanks so much for your help in advance.
Mawi

@sgiehl
Copy link
Member

sgiehl commented Sep 6, 2014

That issue solves exactly that problem. You could try to apply the changes done in 099c969 or wait for the next release

@mattab
Copy link
Member

mattab commented Sep 6, 2014

2.7.0 will be released in ~ 8-10 days so hopefully we can wait

-> Please try upgrading to 2.7.0-b1 which fixes this problem.

@DaSchTour
Copy link
Contributor

There was a similar problem with another 2.x version some months ago. Is there nobody testing for ubuntu 10.04? That's really ugly! So I'll stay at 2.4.0 until a working update comes out…

@merowinbt
Copy link

thanks for the fix, seems to work :)
it's quite annoying though when the requirements are fullfilled and a simple update crashes everything :(

@rroemhild
Copy link

Thanks @diosmosis for the fix! Have a coffee on me! @changetip

@tantalum
Copy link

tantalum commented Sep 9, 2014

Hi,

I had the issue and I was able to resolve it by updating to PHP 5.3.4 on Ubuntu 10.04 using the instructions from http://blog.leenix.co.uk/2011/06/ubuntu-1004-lts-lucid-php-533-backport.html

Simple commands:

sudo apt-get install python-software-properties
sudo add-apt-repository ppa:fabianarias/php5
sudo apt-get update
sudo apt-get upgrade

@mattab
Copy link
Member

mattab commented Sep 24, 2014

Is there nobody testing for ubuntu 10.04? That's really ugly!

We are testing on php 5.3.3 and 5.4 and 5.5 and 5.6 - but we don't test 5.3.2 since travis doesn't offer it

@tantalum
Copy link

Could you please update the requirements to reflect the fact that PHP 5.3.3 or greater is required instead of 5.3.2

@mattab
Copy link
Member

mattab commented Sep 24, 2014

Does Piwik 2.7.0 not work well on PHP 5.3.2 ? We'd like to support it if possible please let us know if you find any bug.

@heinemml
Copy link
Author

On my PHP 5.3.2 Installation 2.7.0 is working well. You should just skip the 2.6.1 Release.

@rroemhild
Copy link

👍 2.7.0 works on Ubuntu 10.04 and PHP 5.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

9 participants