Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem with opt-out-iframe: when calling forwarded to log-in-screen with "idSite= is missing" #6128

Closed
phil-hb opened this issue Sep 5, 2014 · 1 comment
Closed

problem with opt-out-iframe: when calling forwarded to log-in-screen with "idSite= is missing" #6128

phil-hb opened this issue Sep 5, 2014 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone
2.7.0

Comments

@phil-hb
Copy link

phil-hb commented Sep 5, 2014

In Piwik 2.6.1 there is a problem with the opt-out-iframe:

When you call the site with the embedded iframe, the browser is forwarded to this adress:

domain.tld/piwikdirectory/index.php?module=CoreAdminHome&action=optOut&language=en

The log-in-dialogue is presented and an error-message:

      >>Error: The parameter 'idSite=' is missing from the request.<<

Screenshots can be seen here: http://forum.piwik.org/read.php?2,119462,119598

EDIT: This bug only occurs, when you're not logged in to piwik.
@Guite Guite mentioned this issue Sep 5, 2014
Closed
@digedag
Copy link

digedag commented Sep 5, 2014

The \Piwik\Plugins\CoreAdminHome extends \Piwik\Plugin\ControllerAdmin. And ControllerAdmin overwrites methods setBasicVariablesView():

    protected function setBasicVariablesView($view)
    {
        parent::setBasicVariablesView($view);
        self::setBasicVariablesAdminView($view);
    }

The call of method setBasicVariablesAdminView() will stop the request and forces a login action. But this is wrong for optOut-Action.

@mattab mattab added this to the Piwik 2.7.0 milestone Sep 6, 2014
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
4 participants
@mattab @digedag @peterbo @phil-hb