Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When one datatable label is very long it causes the table to stretch overlapping other reports #6121

Closed
tassoman opened this issue Sep 4, 2014 · 10 comments · Fixed by #10397
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@tassoman
Copy link
Contributor

tassoman commented Sep 4, 2014

There's a problem with cells containing too much characters, they make widgets overlap each others.
As you can see in this screenshot the widget on the right overlaps the one on the left that's tooooo wiiiide because of content (AAAAAAAAAAAAAAAAA).

The same happens also in Page Titles cells when you try to make it flat the page goes horizontal, also.

Would be nice some kind of scrollable thing like "sliding doors" behavior. For now I've found this stackOverflow answer

I'm posting a screenshot taken with Firefox on Xubuntu, IE11+win7 behavior is the same.

screenshot-demo piwik org 2016-06-07 12-08-32

@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: UI - UX (AngularJS twig less) labels Sep 8, 2014
@mattab mattab added this to the Mid term milestone Sep 8, 2014
@mattab
Copy link
Member

mattab commented Sep 8, 2014

Thanks for the report!

See also related to issue: Responsive tables #6159

@mattab
Copy link
Member

mattab commented Sep 28, 2014

@tassoman your screenshot is for Piwik 1.12 - do you still experience this issue in 2.7.0 ? if so would you mind posting a screenshot here?

@tassoman
Copy link
Contributor Author

Ok. The previous image was Piwik 2.3.0 using nostalgic 1.x template (users loves it 😨 ).

Now I was able to reproduce using 2.7.0 git tag

My expectation (and user's) was having the cell flowing text and no horizontal scrollbar in the browser

@mattab mattab changed the title Widgets overlapping when width is huuuge When one datatable label is very long it causes the table to stretch overlapping other reports Sep 30, 2014
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. and removed Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Sep 30, 2014
@mattab mattab modified the milestones: Short term, Mid term Sep 30, 2014
@mattab mattab added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. and removed c: UI - UX (AngularJS twig less) labels Oct 12, 2014
@mattab mattab modified the milestones: Short term, Mid term Apr 7, 2015
@mattab
Copy link
Member

mattab commented Apr 7, 2015

@mnapoli maybe this bug would also be solved with #7504 ?

@mnapoli
Copy link
Contributor

mnapoli commented Apr 7, 2015

Mmh I don't think so, the responsive thing should make one column go below the other when the window width is below a threshold. But in the case here it's a problem of overflow-x I guess (i.e. the table and its content span over the column width which is 50% of the screen). It might be easy to fix though, we could move it to 2.13 and I can give it a try?

I think however that #7504 will improve the situation in smaller screens which is where this bug must appear the most (i.e. when columns are collapsed on top of another).

@tassoman
Copy link
Contributor Author

tassoman commented Apr 7, 2015

I've temporally solved this issue using a customized Theme. Inside theme.less I've added this CSS code:

tr.level0 td.label {
  overflow: hidden;
  max-width: 1200px;
}
@media screen and (max-width: 1280px) {
  tr.level0 td.label {
    max-width: 700px;
  }
}
@media screen and (max-width: 1024px) {
  tr.level0 td.label {
    max-width: 350px;
  }
}

It tries to arbitrarily adapt cell with in different screen sizes.

@tassoman
Copy link
Contributor Author

tassoman commented Jun 12, 2016

I'll work on the custom theme further with @jdeyla then, if we reach a working solution, I'll go for a PR

@tsteur
Copy link
Member

tsteur commented Jun 13, 2016

Awesome 👍 looking forward to it. BTW: In Piwik 3 we will likely solve it by letting users scroll dataTables when they are too wide until we have completely responsive tables

@mattab
Copy link
Member

mattab commented Jul 8, 2016

In Piwik 3 we will likely solve it by letting users scroll dataTables when they are too wide until we have completely responsive tables

👍

@sgiehl
Copy link
Member

sgiehl commented Nov 19, 2017

Datatables are now scrollable when they are too wide:
image

@sgiehl sgiehl closed this as completed Nov 19, 2017
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants