Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report notices to error log #6119

Closed

Conversation

splinter89
Copy link
Contributor

Hi!
I'm using the latest Piwik 2.5.0 and I'm seeing lots of notices in my php error log (they are generated by plugins).
I guess intended behavior was to ignore notices, but there are E_ALL | E_NOTICE everywhere.

var_dump([E_ALL, E_NOTICE, E_ALL | E_NOTICE, E_ALL & ~E_NOTICE]);
/*
array(4) {
  [0] =>
  int(32767)
  [1] =>
  int(8)
  [2] =>
  int(32767)
  [3] =>
  int(32759)
}
*/

馃槈

@ThaDafinser
Copy link
Contributor

-1
Not reporting notices is as bad as the @ prefix. The only right way to go is to fix them!

Keep in mind that even notices can lead to strange errors

@splinter89
Copy link
Contributor Author

Yeah, I agree. I'll change it to just E_ALL because current E_ALL | E_NOTICE is strange and misleading.

@mattab
Copy link
Member

mattab commented Sep 8, 2014

Thanks for the PR! as @ThaDafinser pointed out we would want to fix the notices rather than hide them.

Maybe you could send pull request that fix the notice messages instead? Cheers,

Matt

@mattab mattab closed this Sep 8, 2014
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Sep 8, 2014
@splinter89
Copy link
Contributor Author

Hm... So you didn't even look at changes?
Btw, I've already wrote that notices come from plugins, and Piwik itself is OK.

@mattab
Copy link
Member

mattab commented Sep 8, 2014

Hm... So you didn't even look at changes?

Yes I looked at changes.

Btw, I've already wrote that notices come from plugins, and Piwik itself is OK.

Ok then maybe report the notice in the plugin github issues tracker.

@splinter89 splinter89 deleted the error-reporting-level branch September 8, 2014 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants