Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP in Providers widget is linking to FAQ page. #6101

Closed
MichalTomczak opened this issue Sep 1, 2014 · 2 comments
Closed

IP in Providers widget is linking to FAQ page. #6101

MichalTomczak opened this issue Sep 1, 2014 · 2 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@MichalTomczak
Copy link

While embeding a Providers Widget to a page, a clickable provider "IP" is linked to Piwik FAQ. We, discussed this and think that it shouldn't be like that. It should be called "Unknown" or something like that and maybe insted of link to FAQ there should be an information popup. This Way user can embeed the widget without revealing that it is actually Piwik.
https://github.com/piwik/piwik/blob/master/plugins/Provider/functions.php#L50

@mattab mattab added this to the Piwik 2.8.0 milestone Sep 2, 2014
@mattab
Copy link
Member

mattab commented Sep 2, 2014

Thanks for the suggestion.

Tasks

  • change from IP to Unknown
  • in the report footer, we could write Unknown provider means the IP could not be looked up. See <a href='http://piwik.org/faq/general/faq_52/'>this faq</a>.
  • update the faq
  • when disableLink is used, we could hide the link to piwik.org

@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Sep 15, 2014
@mnapoli mnapoli self-assigned this Oct 8, 2014
@mnapoli
Copy link
Contributor

mnapoli commented Oct 8, 2014

Pull request: #6400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants