Removing pre PHP 5.3 checks (SPL ArrayObject) #6084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess removing the SPL check would be fine, as there is no way to disable it as of 5.3. But it should still be possible to disable JSON while compiling php using --disable-all option or something like that. JSON is only enabled by default. So this check is imho still required. Isn't it? |
|
You are right. Just saw this note: http://php.net/manual/en/json.installation.php#113869 |
| @@ -10,7 +10,6 @@ | |||
| /** | |||
| * This file is executed before anything else. | |||
| * It checks the minimum PHP version required to run Piwik. | |||
| * This file must be compatible PHP4. | |||
There was a problem hiding this comment.
this comment is useful could you bring it back?
|
Thanks for the PR! |
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPL is build in since 5.0 and always available since 5.3: http://php.net/manual/en/spl.installation.php
JSON is build in since 5.2: http://php.net/manual/en/json.installation.php