Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP4 comment #6083

Closed
wants to merge 1 commit into from
Closed

Remove PHP4 comment #6083

wants to merge 1 commit into from

Conversation

ThaDafinser
Copy link
Contributor

No description provided.

@mattab
Copy link
Member

mattab commented Aug 28, 2014

Comment is useful, the code above that comment must be php4 compatibel, so that when someone loads piwik on php4 it displays nice error message rather than parse error.

@mattab mattab closed this Aug 28, 2014
@ThaDafinser
Copy link
Contributor Author

@mattab just a wow for that...since PHP 5.3 is EOL, Piwik still cares about PHP4? Again wow

@halfdan
Copy link
Member

halfdan commented Aug 28, 2014

@ThaDafinser It is solely to provide an error message and show the user that his version of PHP is not supported. We care about 5.3 since ~50% of users still use that version of PHP.

@kylekatarnls
Copy link
Contributor

Agree with mattab. It seem, there is still 2% of PHP 4 users:
http://w3techs.com/technologies/details/pl-php/all/all
If a message require explicitly PHP 5, they will not lose time and we can hope they will upgrade. Else maybe they will not even understand what happend and why Piwik does not works.

@mattab mattab added the wontfix label Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants