Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When new plugins are released on the marketplace, the CI build should not always fail #6076

Closed
mattab opened this issue Aug 27, 2014 · 2 comments
Closed

When new plugins are released on the marketplace, the CI build should not always fail #6076

mattab opened this issue Aug 27, 2014 · 2 comments
Labels
c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
Long term

Comments

@mattab
Copy link
Member

mattab commented Aug 27, 2014

Context

When a new plugin is released on the marketplace we have a script that runs the Piwik unit + plugins + system tests. This is meant to detect easily whenever some plugins fail the Piwik platform tests. This setup is for information purpose only.

Example

When the plugin LdapConnection 0.3.0 was released, this build ran:
https://travis-ci.org/piwik/piwik-tests-plugins/builds/33558430

This build and all builds triggered on new release are failing in similar way.

The goal of this ticket is to make the build pass if the plugin does not cause any test to fail. (eg. if plugin adds widget or reports then it will fail and that's fine).
@mattab mattab added this to the Piwik 2.7.0 milestone Aug 27, 2014
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Sep 15, 2014
@mattab mattab modified the milestones: Piwik 2.9.0, Piwik 2.8.0 Oct 2, 2014
@mattab mattab self-assigned this Oct 10, 2014
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Oct 10, 2014
@mattab mattab modified the milestones: Piwik 2.9.0, Piwik 2.10.0 Oct 23, 2014
@mattab mattab removed their assignment Nov 13, 2014
@mattab mattab removed the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Dec 11, 2014
@diosmosis diosmosis self-assigned this Dec 15, 2014
diosmosis pushed a commit that referenced this issue Dec 29, 2014
Refs #6076, refactor .travis.yml generation code and allow more than …
2847e40 
…2 contexts for generation. Added context for generating the .travis.yml file for piwik-tests-plugins repo.
@mattab mattab modified the milestones: Piwik 2.10.0 , Piwik 2.11.0 Jan 4, 2015
@diosmosis
Copy link
Member

Next steps:

  1. Modify marketplace code so instead of creating a branch to test plugins a commit is made so the .travis.yml file autoupdates.
  2. Continue fixing causes for test failures.

@diosmosis diosmosis removed their assignment Feb 9, 2015
@mattab
Copy link
Member Author

mattab commented Feb 9, 2015

Moved to 2.12.0 - maybe this will be done along with #6539 since 6539 may need the piwik-tests-plugins build to run the Phpstorm plugin that will detect @api and @deprecated calls - as mentioned by @diosmosis

@mattab mattab modified the milestones: Piwik 2.12.0, Piwik 2.11.0 Feb 9, 2015
@mattab mattab modified the milestones: Mid term, Piwik 2.12.0 Mar 13, 2015
@mattab mattab closed this as completed Aug 16, 2016
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
2 participants
@diosmosis @mattab