Use an event to collect visitor information and made sure UI works even when minimum plugins are enabled #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Piwik UI kinda works when most tracker plugins are disabled
…ting / tracker plugins is enabled
…f integration tests tmrw
…hose widget entries appear first in the list
… properties has changed
…lugin is disabled first and activated later it will not crash the live API as there might be some visitors having no referrer type
tsteur
added a commit
that referenced
this pull request
Aug 26, 2014
Use an event to collect visitor information and made sure UI works even when minimum plugins are enabled
|
really like this pull request! Building a platform FTW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6045 #6049
Disabled most or even all tracker and reporting plugins and Piwik UI still works now. There were a couple of issues, for instance the menu, some templates, ... So far there is only one event to add visitor information to the API. I am not sure how to solve the UI part. Would be quite difficult to trigger events there and to make sure everything is in the correct order. So leaving the template part as it is but made sure there won't be any errors in case a property is not set.