Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store list of enabled plugins in Database #6063

Open
mattab opened this issue Aug 25, 2014 · 3 comments
Open

Store list of enabled plugins in Database #6063

mattab opened this issue Aug 25, 2014 · 3 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Aug 25, 2014

Currently the list of enabled plugins is stored in the config.ini.php.

Goal of this ticket is to store the list of enabled plugins in the database instead.

Benefit: this will ensure that list of enabled plugins is synchronised across all servers used by Piwik, without having to manually synchronise it whenever new plugins are enabled/disabled.

Tasks

  • store plugins in Database (eg. piwik_option table, with autoload=1)
  • make PluginsManager load the list from DB
  • make Tracker cache the list of tracker plugins in Tracker cache

see also #6529
@mattab mattab added this to the Short term milestone Aug 25, 2014
@mattab mattab mentioned this issue Aug 25, 2014
Closed
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 9, 2014
@mattab mattab modified the milestones: Piwik 2.11.0, Short term Dec 18, 2014
@mnapoli
Copy link
Contributor

mnapoli commented Dec 22, 2014

That would mean that plugins could never be able to customize the DB configuration or implementation being used, because the DB would need to be created before loading the plugins.

@mattab mattab modified the milestones: Short term, Piwik 2.11.0 Dec 22, 2014
@mattab
Copy link
Member Author

mattab commented Dec 22, 2014

Good point, I'm moving it out of milestone as Im not sure this is so important anymore...

@mattab mattab removed the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Dec 22, 2014
@mattab mattab modified the milestones: Short term, Mid term Apr 7, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab mattab mentioned this issue May 2, 2018
Open
@tsteur tsteur mentioned this issue Feb 29, 2020
Closed
@rick-pri
Copy link

Good point, I'm moving it out of milestone as Im not sure this is so important anymore...

This is important for users with multiple Matomo app servers behind load balancers and ensuring that if you install the package that it is installed everywhere and available everywhere (there's probably a requirement that all nodes are triggerable on updating the list of plugins. At the moment I'm using configuration management to git clone the plugin into the directory and to push out the config file onto all the servers to enable the plugin.) Using a settings file in such a context does not make any sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@mattab @mnapoli @rick-pri