Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move translations from core to plugins and cache all plugin translations for better performance #6059

Merged
merged 10 commits into from Aug 25, 2014

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 25, 2014

refs #5863

We do now always load all translations of all plugins shipped via core as well as all loaded plugins.

tsteur and others added 10 commits August 24, 2014 21:14
…e always load all translations of all plugins that are not 3rd party and bogus. As the translation file will be cached the time to load the translation drops from > 10ms to 1ms
…r will try to load plugin translation directly after loading the plugin when the plugin translations are not loaded yet. Maybe better fix would be to defer loading the plugin getInformation until needed. Could also bring performance improvement
…therwise langCode will be always an empty string. If there is no plugin loaded yet and no language generate a simple cache file for core translations, load a translation only if a langCode is there
…ss the config and it did not exist at this time
tsteur added a commit that referenced this pull request Aug 25, 2014
fixes #5863 Move translations from core to plugins and cache all plugin translations for better performance
@tsteur tsteur merged commit 07ee831 into master Aug 25, 2014
@tsteur tsteur deleted the 5863_languageFilesInPlugin branch August 25, 2014 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants