Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hooks to Live plugin and let other plugins extend it #6045

Closed
tsteur opened this issue Aug 22, 2014 · 5 comments
Closed

Add hooks to Live plugin and let other plugins extend it #6045

tsteur opened this issue Aug 22, 2014 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.7.0

Comments

@tsteur
Copy link
Member

tsteur commented Aug 22, 2014

Needed to move provider plugin to Marketplace see #5341.

Also need to prevents issues like this http://forum.piwik.org/read.php?2,118765,119048 there Visitors in real time and Visitor Log becomes unusable if for instance Referrers plugin is deactivated. See #6049
@tsteur tsteur added this to the Piwik 2.6.0 milestone Aug 22, 2014
@tsteur tsteur added the Bug label Aug 22, 2014
@tsteur tsteur mentioned this issue Aug 23, 2014
Closed
@tsteur tsteur self-assigned this Aug 25, 2014
tsteur added a commit to matomo-org/matomo-mobile-2 that referenced this issue Aug 26, 2014
@tsteur
refs matomo-org/matomo#6045 made sure app works when user has not ena…
641a655 
…bled any plugins except Live
tsteur added a commit that referenced this issue Aug 26, 2014
@tsteur
refs #6045 #6049 added an event to collect visitor info and made sure…
ade4198 
… the Piwik UI kinda works when most tracker plugins are disabled
tsteur added a commit that referenced this issue Aug 26, 2014
@tsteur
refs #6045 #6049 the UI should now work even when none of those repor…
b881b1d 
…ting / tracker plugins is enabled
tsteur added a commit that referenced this issue Aug 26, 2014
@tsteur
refs #6045 fixing already core and pluginsTests, need to check diff o…
1dbe9aa 
…f integration tests tmrw
tsteur added a commit that referenced this issue Aug 26, 2014
@tsteur
refs #6045 now I understand why it was defined in postLoad. To make t…
938d673 
…hose widget entries appear first in the list
tsteur added a commit that referenced this issue Aug 26, 2014
@tsteur
refs #6045 fixed some tests as due to the event the order of the live…
64cc9d2 
… properties has changed
@tsteur tsteur mentioned this issue Aug 26, 2014
Merged
tsteur added a commit that referenced this issue Aug 26, 2014
@tsteur
refs #6045 added description for event. also made sure if Referrers p…
3ea7b11 
…lugin is disabled first and activated later it will not crash the live API as there might be some visitors having no referrer type
@tsteur
Copy link
Member Author

tsteur commented Aug 26, 2014

Done! Although it is only a first step. Once we have DI we can handle all this much better by not using events but extending/decorating the visitor class and also the other API methods such as getVisitorProfile(). I think we will get this more or less out of the box.

As mentioned in the pull requests it is not fully dynamically as the templates are still "hard coded" and plugins still cannot extend the UI part. So leaving it open for now

@tsteur tsteur removed their assignment Aug 26, 2014
@mattab
Copy link
Member

mattab commented Sep 2, 2014

Well done @tsteur !

@mattab mattab closed this as completed Sep 2, 2014
@tsteur
Copy link
Member Author

tsteur commented Sep 2, 2014

What about the templates? Are we planning on making them extendable as well? Maybe we should create a ticket for that when you are closing this one?

@mattab
Copy link
Member

mattab commented Sep 2, 2014

Maybe we should create a ticket for that when you are closing this one?

absolutely
@tsteur would you mind creating the follow up issue as you see eg in Short term milestone?

@tsteur tsteur mentioned this issue Sep 3, 2014
Closed
@tsteur
Copy link
Member Author

tsteur commented Sep 3, 2014

See #6111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@tsteur @mattab