fixed composer.json to download the same set of vendors as with use of c... #6043
Conversation
…f composer.lock. that way Piwik can be also installed with Composer as dependency along with its dependencies
@mgazdzik I think that when there is a new version of twig or leafo etc. from our composer.json, then this problem will re-occur again that there could be mismatch between the downloaded version (when including Piwik as composer dependency) and the one specified in composer.lock So i'm not sure if this will fix future problems but anyway +1 for mering this PR as it is. |
fixed composer.json to download the same set of vendors as with use of c...
|
I think that if all vendors would be defined with strict versioning in both - composer.lock (which is by defaul) and in composer.json (which I'm hoping can be introduced) we shouldn't ever have this problem again. After there is some change in any vendor that we want to introduce - simply put it in composer.jsom first, and then refresh composer.lock using "composer update". This way both files will contain the same version tag and will point to the same commit. |
|
@mgazdzik ok that makes sense I think! Could you create issue to keep track of this request? |
...omposer.lock. that way Piwik can be also installed with Composer as dependency along with its dependencies.
Originally this issue came out when I tried to download Piwik along with it's plugins using different composer.json file. That way Composer would download dependencies described in composer.json. This caused installation and Piwik in general to break down due to vendor version mismatch. In 'standard' use case on the other hand it worked well, as strict version was stored inside of composer.lock file.
Tilde operator is not quite safe for precise version marking (ref. https://getcomposer.org/doc/01-basic-usage.md#next-significant-release-tilde-operator- ) , so I would propose to always keep composer.json and composer.lock up-to-date using precise versioning in composer.json, so Piwik can be managed with Composer easily.
For now I have found that lessphp was causing problems after download, but it generally could be a good idea to switch to strict versioning for all vendors.