Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating segments matching page Urls, apply lowercase automatically #6041

Closed
mattab opened this issue Aug 21, 2014 · 2 comments
Closed
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@mattab
Copy link
Member

mattab commented Aug 21, 2014

Goal of this ticket is to make creating segments matching URLs easier, and prevent a type of user error. In particular, we want to prevent the user from entering mix of lowercase and uppercase URLs paths and automatically use the lowercase URLs/paths.

Tasks:

  • Check that Piwik stores all URLs in lowercase
  • Apply lowercase filter to the Page URL segment (and other URLs segments)
  • add a test
  • maybe there are other visit or page attributes that are lowercased by Piwik tracker and could get same automatic lowercase treatment?
@mattab mattab added this to the Piwik 2.6.0 milestone Aug 21, 2014
@mattab mattab added the Task label Aug 21, 2014
@mattab mattab self-assigned this Sep 2, 2014
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Sep 15, 2014
@mattab mattab modified the milestones: Piwik 2.8.0, Piwik 2.7.0 Sep 24, 2014
@mattab mattab removed their assignment Oct 8, 2014
@mattab mattab modified the milestones: Piwik 2.9.0, Piwik 2.8.0 Oct 14, 2014
@mattab mattab modified the milestones: Piwik 2.9.0, Piwik 2.8.1 Oct 19, 2014
@mattab mattab assigned mattab and unassigned diosmosis Oct 20, 2014
@mattab mattab modified the milestones: Mid term, Piwik 2.8.1 Oct 20, 2014
@diosmosis
Copy link
Member

Related: #6471 and #6472

@mattab mattab modified the milestones: Long term, Mid term Nov 15, 2014
@mattab mattab removed their assignment Nov 15, 2014
@mattab
Copy link
Member Author

mattab commented Sep 11, 2015

Won't fix, see also #8579

@mattab mattab closed this as completed Sep 11, 2015
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants