Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sqlmode STRICT_TRANS_TABLES #6039

Closed
mattab opened this issue Aug 21, 2014 · 1 comment
Closed

Support sqlmode STRICT_TRANS_TABLES #6039

mattab opened this issue Aug 21, 2014 · 1 comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Aug 21, 2014

Several users are using Mysql with STRICT_TRANS_TABLES

This is causing some issue as some small part of code from Piwik are not compatible with this SQL mode.

eg.

The goal of this ticket is to set
- mysql -e "SET GLOBAL sql_mode = 'NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES'"

in https://github.com/piwik/piwik/blob/master/plugins/CoreConsole/templates/travis.yml.twig
and make all tests pass.
@mattab mattab added this to the Short term milestone Aug 21, 2014
@mattab mattab added the Task label Aug 21, 2014
mattab pushed a commit that referenced this issue Aug 21, 2014
refs #6039 revert STRICT_TRANS_TABLES until we tackle it
079bb73
@mattab
Copy link
Member Author

mattab commented Aug 21, 2014

duplicates #5178

@mattab mattab closed this as completed Aug 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
1 participant
@mattab