Fix xhprof integration, install xhprof through composer and build xhprof through composer. #6035
Conversation
| return; | ||
| $xhProfPath = PIWIK_INCLUDE_PATH . '/vendor/facebook/xhprof/extension/modules/xhprof.so'; | ||
| if (!file_exists($xhProfPath)) { | ||
| throw new Exception("Cannot find xhprof, run 'composer update' and build the extension."); // TODO: automate building w/ composer |
There was a problem hiding this comment.
// TODO: automate building w/ composer
maybe it's done already as I see it in composer.json?
…ion and correctly aggregate xhprof runs (xhprof aggregation will always normalize so we must aggregate ourselves).
diosmosis
force-pushed
the
5995_xhprof_improvements
branch
from
61fae4a
to
692ecd8
Compare
|
looks good to me @sgiehl any idea why the coveralls comments indicate -25% coverage when this PR should not impact code coverage? |
|
Yes. The coverage is built out of three travis builds. Coveralls seems to comment as soon as the first data arrives. As soon as other data arrives it updates the comment. In that case only data of Core tests arrived. Plugin test didn't because of a coveralls server failure and the part of Integration tests timed out after 50 minutes... |
|
Shall I disable that feature for now? |
…ilerXHProf that are no longer necessary.
Fix xhprof integration, install xhprof through composer and build xhprof through composer.
@sgiehl +1 for disabling the feature for now (maybe in couple months we could look at it again?) |
As title. Refs #5995.