Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #6013 use console only if executed from cli #6016

Merged
merged 2 commits into from Aug 19, 2014

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 18, 2014

refs #6013 #6012 The created issue makes absolutely sense I think as a command would be executed only in CLI mode anyway see https://github.com/piwik/piwik/blob/master/core/Plugin/ConsoleCommand.php#L30

What I am not sure is whether HHVM & co reports itself as CLI/CGI as well? But this is maybe worth a separate issue.

@mattab Please merge if you cannot think of any problems with that.

…I. In type CGI the argv should not be registered anyway unless maybe for instance register-argc-argv is enabled
tsteur added a commit that referenced this pull request Aug 19, 2014
refs #6013 use console only if executed from cli
@tsteur tsteur merged commit 5a43d80 into master Aug 19, 2014
@tsteur
Copy link
Member Author

tsteur commented Aug 19, 2014

Users reported it works for them so merged

@tsteur tsteur deleted the 6013_useConsoleOnlyIfCli branch August 19, 2014 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant