refs #6013 use console only if executed from cli #6016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6013 #6012 The created issue makes absolutely sense I think as a command would be executed only in CLI mode anyway see https://github.com/piwik/piwik/blob/master/core/Plugin/ConsoleCommand.php#L30
What I am not sure is whether HHVM & co reports itself as CLI/CGI as well? But this is maybe worth a separate issue.
@mattab Please merge if you cannot think of any problems with that.