You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should rename some methods to prevent possible bugs in the future. For instance I was using the loadPlugin() method because I was assuming a different behavior based on the name. Especially the naming should be clarified. I already added some doc blocks but we all know nearly nobody is reading them :)
returnLoadedPluginsInfo() does not return only the loaded plugins but it loads all even not activated ones. So next call to getLoadedPlugins() will return all plugins, even not activated ones whereas before only activated ones are returned.
loadPlugin() only loads a plugin
loadPlugins() loads and activates plugins. Whereas loadPlugin adds one new plugin I would assume loadPlugins adds multiple new plugins but it actually overwrite (sets) the activated plugins.
There might be some more methods that could be renamed. As it is not a public API it should not be a problem.
The text was updated successfully, but these errors were encountered:
We should rename some methods to prevent possible bugs in the future. For instance I was using the loadPlugin() method because I was assuming a different behavior based on the name. Especially the naming should be clarified. I already added some doc blocks but we all know nearly nobody is reading them :)
returnLoadedPluginsInfo()
does not return only the loaded plugins but it loads all even not activated ones. So next call to getLoadedPlugins() will return all plugins, even not activated ones whereas before only activated ones are returned.loadPlugin()
only loads a pluginloadPlugins()
loads and activates plugins. Whereas loadPlugin adds one new plugin I would assume loadPlugins adds multiple new plugins but it actually overwrite (sets) the activated plugins.There might be some more methods that could be renamed. As it is not a public API it should not be a problem.
The text was updated successfully, but these errors were encountered: