Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3316] Add request parameter option to disable seriesPicker on jqplot #6

Closed

Conversation

chmielot
Copy link

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Tests pass: -
Fixes the following tickets: #3316
Todo: -
License of the code: MIT

Use case: Using Widgetize-Plugin to display certain widgets on a website:

<div id="widgetIframe">
<iframe width="100%" 
    height="350" 
    src="http://host/piwik/index.php?module=Widgetize&action=iframe&columns[]=nb_visits,nb_pageviews&moduleToWidgetize=VisitsSummary&actionToWidgetize=getEvolutionGraph&idSite=1&period=month&date=today&disableLink=1&widget=1&seriesPicker=0" 
    scrolling="no" 
    frameborder="0" 
    marginheight="0" 
    marginwidth="0" 
    id="visitssum"></iframe>
</div>

This widget should be a limited version of the real piwik widgets, so you want to disable other series for the graph. Currently there is no option to disable the series picker in jqPlot, it is always activated as long as there are other series types for the requested graph.

I am aware of the fact that the URL can be manipulated to show other graph types. This is not important as the end user is assumed to not be able to do it. On the other hand, this could be prevented by apache rules for example.

This patch allows to set request parameter "seriesPicker" to 0 to disable the seriesPicker.

@robocoder robocoder closed this Aug 26, 2012
@halfdan halfdan mentioned this pull request Jul 1, 2009
sgiehl added a commit that referenced this pull request Feb 13, 2024
sgiehl added a commit that referenced this pull request Feb 15, 2024
)

* [Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.*

* Apply coding style around FunctionCallSignature #1 (#21927)

* Apply coding style around FunctionCallSignature #2 (#21928)

* Apply coding style around FunctionCallSignature #3 (#21929)

* Apply coding style around FunctionCallSignature #4 (#21930)

* Apply coding style around FunctionCallSignature #5 (#21931)

* Apply coding style around FunctionCallSignature #6 (#21932)

* Apply coding style around FunctionCallSignature #7 (#21933)

* Apply coding style around FunctionCallSignature #8 (#21934)

* Apply coding style around FunctionCallSignature #9 (#21935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants