Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XHProf implementation #5995

Closed
tsteur opened this issue Aug 13, 2014 · 1 comment
Closed

Fix XHProf implementation #5995

tsteur opened this issue Aug 13, 2014 · 1 comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
Backlog (Help wan...

Comments

@tsteur
Copy link
Member

tsteur commented Aug 13, 2014

Problems with the current implementation:

We could remove XHProf from Piwik entirely or we can actually fix this issue. There is no final decision on that. It would be probably nice if XHProf could be activated easily.
@tsteur tsteur added this to the Short term milestone Aug 13, 2014
@diosmosis diosmosis mentioned this issue Aug 20, 2014
Merged
@diosmosis
Copy link
Member

Closed by #6035.

diosmosis pushed a commit that referenced this issue Aug 22, 2014
Refs #5995, do not access piwik URL for non-main runs when running xh…
dae8ab5 
…prof since it initializes the config object.
diosmosis pushed a commit that referenced this issue Aug 22, 2014
Refs #5995, do not access piwik URL for non-main runs when running xh…
5f06c87 
…prof since it initializes the config object.
tsteur added a commit that referenced this issue Aug 25, 2014
@tsteur
refs #5995 XHProf failed on PHP 5.3.10 on Ubuntu with a fatal error b…
8008b2a 
…ecause those methods were private. Also one should rather execute composer install instead of update, otherwise one would update packages instead of installing the current defined versions
mattab added a commit that referenced this issue Sep 4, 2014
@mattab
refs #5995 Remove xhprof, and other phpunit dependencies, from the ve…
8a831d1 
…ndors to keep builds light
mattab added a commit that referenced this issue Sep 5, 2014
@mattab
refs #5995 Remove xhprof, and other phpunit dependencies, from the ve…
98b846f 
…ndors to keep builds light

(cherry picked from commit 8a831d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@diosmosis @tsteur