refs #5936 remove gone files during update #5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s directories that are no longer present in the new build
…re they only delete the files they are supposed to do
… also brings the advantage to make it better testable. Controller should be always simple/small... removeGoneFiles() is not really testable as it uses the static filesystem and I did not want to make the code ugly to mock it... Looking forward to dependency injection
tsteur
added a commit
that referenced
this pull request
Aug 12, 2014
refs #5936 remove gone files during update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the ticket when updating Piwik it will compare all directories within the plugins folder and the core directory of the latest.zip with the current installation and remove all files that are in the users current installation but not in the latest.zip.
To test it one has to update Piwik to make sure the CoreUpdater uses this new codebase and then update again to a later version. So it won't work directly with the next update. Maybe we can release to new betas and update after each?