Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve main menu visualisation when there are many goals #5977

Closed
quba opened this issue Aug 11, 2014 · 14 comments
Closed

Improve main menu visualisation when there are many goals #5977

quba opened this issue Aug 11, 2014 · 14 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@quba
Copy link
Contributor

quba commented Aug 11, 2014

The idea is to have goals grouped instead of having them in the submenu. They could be grouped similar to segments with additional possibility to search by name.

@mattab mattab added this to the Short term milestone Aug 11, 2014
@mattab mattab added the Major label Aug 11, 2014
@mattab
Copy link
Member

mattab commented Aug 11, 2014

Thanks for the suggestion! Maybe someone has an idea on how this could be achieved? when we have some idea about the design then i'll move it to next version milestone (eg. 2.6.0)

@quba quba changed the title Improve main menu visualisation when there are many segments Improve main menu visualisation when there are many goals Aug 12, 2014
@diosmosis
Copy link
Member

Possible solutions:

  • Remove individual goals pages and replace with a single 'Single Goal Summary' page. On the page will be a dropdown that lists each goal (and maybe some quick info about the goal, like [ triggered when url contains '...']). Changing the goal dropdown value would change the page for the selected goal.
  • Changing the menu so the list of items is ellipsized (ie, 'Goal 1' 'Goal 2' 'Goal 3' ...) and making the ellipses a link that shows a dropdown for the extra menu items.

I do not know what will work best, however.

@quba
Copy link
Contributor Author

quba commented Aug 12, 2014

Here's proposed solution: http://vm8ttr.axshare.com

@tsteur
Copy link
Member

tsteur commented Aug 15, 2014

+1 for the proposed solution with dropdown (maybe only in case there are more than for instance 2 or 3 goals)

@quba
Copy link
Contributor Author

quba commented Aug 18, 2014

@mattab: Is it possible to have it done in 2.6.0?

@mattab
Copy link
Member

mattab commented Aug 18, 2014

@quba moved issue to 2.6.0

+1 to show it only when more than 3 goals (as it looks fine when there are only 3 goals)

@mattab mattab modified the milestones: Short term, Piwik 2.6.0 Aug 18, 2014
@tsteur tsteur self-assigned this Aug 19, 2014
tsteur added a commit that referenced this issue Aug 19, 2014
…used an existing menuDropDown component that was already used for Language and Usermenu. I removed the round border there as all our other components to not have round corners. Also had to add some z-index because Segment and Date picker define a z-index. So to make sure the components are correct visible I had to add a z-index to the submenu and therefore to the top menu. I hope this does not introduce any side effects. Tested with leftMenu and with ZenMode...
@tsteur
Copy link
Member

tsteur commented Aug 19, 2014

It'll always show "Choose Goal" by default unless you actually select a goal. On page reload it'll show "Choose Goal" again but the title of the current goal is at least visible in the view below. Didn't find a way so far to identify which one should be opened.

The dropdown will only show if more than 3 goals. Anyone wants to give it a try?

@quba
Copy link
Contributor Author

quba commented Aug 19, 2014

Looks cool!

Maybe we could leave the ability to add new goal? Currently it is only displayed when there are no goals and I think it's confusing.

@tsteur
Copy link
Member

tsteur commented Aug 20, 2014

Closing it for now. Feel free to reopen if any problems occur. @mattab maybe you also want to have a look at it.

@tsteur tsteur closed this as completed Aug 20, 2014
@mattab
Copy link
Member

mattab commented Aug 20, 2014

Looks really good!

Here is some feedback:

  • When clicking on the selector, put the autofocus in the search field
    • Advantages: allows for quick searching, similar behaviour to Website selector
  • When Enter key is pressed, open the currently selected goal
    • if there is only one goal matching the searched string, then simply pressing enter will load this goal
  • On hover on Goal name in the selector, display a tooltip $Goal name (id = $X)

I found a couple little bugs:

bug 1)

  • click on Goals > Overview.
  • click on one of the goals in selector Download Piwik
  • click on Goals > Overview.
  • got: the goal selector displays Download Piwik. Expected: Choose goal

bug 2)

  • click on Goals > Overview.
  • in the overview, click on a H2 title eg. Goal 'Download Piwik'
  • got: the goal selector displays Choose goal. Expected: Download Piwik is shown in the goal selector.

@mattab mattab reopened this Aug 20, 2014
@tsteur
Copy link
Member

tsteur commented Aug 20, 2014

I'm aware of "bug" or "feature" 1 and 2 but was ok with that as it can take even days to make this nice working. Would be no issue at all with Angular Routing etc. :)

  • Put the autofocus: OK
  • Pressing enter and using arrow keys can take easily a day of work as well since needs quite some changes as the component is not fully AngularJS
  • On hover: OK although I do not really see the point displaying the ID there

@mattab
Copy link
Member

mattab commented Aug 20, 2014

it can take even days to make this nice working. Would be no issue at all with Angular Routing etc. :)

Would you mind create a ticket for Angular routing?
Maybe we could work on this in next few months, as we recently quite often mentioned this.

@tsteur
Copy link
Member

tsteur commented Aug 21, 2014

done #6037

@mattab
Copy link
Member

mattab commented Aug 23, 2014

Looks good, I created follow up issue #6052

@mattab mattab closed this as completed Aug 23, 2014
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

4 participants