Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default date when adding annotations #5972

Closed
rivadav opened this issue Aug 11, 2014 · 7 comments
Closed

Wrong default date when adding annotations #5972

rivadav opened this issue Aug 11, 2014 · 7 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@rivadav
Copy link

rivadav commented Aug 11, 2014

Problem
When I try to add new annotation on the selected day on the graph, the default date is set automatically on the current day.

It's a problem, because I have to change it manually. If I don't do it, I may not see that the annotations has been added.

vuowo1ewmb

Solution
When user tries to add an annotation directly on the graph, the date should automatically adjust to selected day.

@rivadav rivadav changed the title [UI] Wrong default date when adding annotations Wrong default date when adding annotations Aug 11, 2014
@mattab mattab added this to the Piwik 2.6.0 milestone Aug 11, 2014
@tsteur
Copy link
Member

tsteur commented Aug 15, 2014

Well, we changed this recently because of #4888 as requested by a user and I think today makes more sense since you would usually rather add a new annotation for today than a month ago. You would otherwise always have to change the date to today

@rivadav
Copy link
Author

rivadav commented Aug 19, 2014

@tsteur

When I click on the annotation icon for July 16th I expect to see annotations for this day and it’s correct since I can clearly see it above. So from my point of view it’s only logical that when I click “Create new annotation” and create it under this date. It makes reviewing charts easy and natural.

Perhaps we should find another way to enable users to create annotation on the current day because it seems to be the problem?

Current solution also fails when I have selected time range which doesn’t include current day - I don’t know if note is added or not.

@tsteur
Copy link
Member

tsteur commented Aug 25, 2014

If you find another solution let me know. I think in most cases users want to create an annotation for today so it is quite important. User in #4888 assumes the same. Maybe we can display it a bit differently or position it somewhere else so that there is no reference to the selected date. Maybe we could position the "create new annotation" link above "Annotations 16 Jul 14"...

There could be also too links "create annotation for today" and "create annotation for 16 Jul 14" but this is rather a workaround/hack.

@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Sep 15, 2014
@mattab
Copy link
Member

mattab commented Sep 21, 2014

Proposed solution:

  • when user clicks on a given date on the calendar and click "create new annotation" then the date should be set to the clicked calendar date.
  • when user clicks on "Annotations" link next to the icon and then click on "create new annotation" then the date should be set to today.

@tsteur
Copy link
Member

tsteur commented Sep 22, 2014

Could be a bit confusing for power users but could also work :) Never noticed this annotation button there before. It's very hard to notice there. Maybe could be improved as well.

Maybe in this case the date picker could show two additional buttons "today" and "yesterday" when opening it to quickly select one of those values and not having to switch to the next month etc.

@rivadav
Copy link
Author

rivadav commented Sep 22, 2014

+1 for @mattab "when user clicks on a given date on the calendar and click "create new annotation" then the date should be set to the clicked calendar date."

+1 for @tsteur "the date picker could show two additional buttons "today" and "yesterday" when opening it"

Combining these two solutions we'll make sure that average users can easily use this feature and power users can quickly change date.

tsteur added a commit that referenced this issue Sep 23, 2014
…t select the date directly and it is not possible to add another button for yesterday which are both quite annoying. When moving to Angular we better choose another calendar
tsteur added a commit that referenced this issue Sep 23, 2014
…nd select the clicked date when clicking on a specific day. It still does not show today as default when clicking on annotation.
tsteur added a commit that referenced this issue Sep 23, 2014
@tsteur
Copy link
Member

tsteur commented Sep 23, 2014

Should work. As mentioned in a previous commit the calendar today picker does not directly select the date which is annoying and the calendar component does not allow to add another button yesterday.

Will close it once seeing screenshot tests. For me this solution is still only a workaround. It would be nicer to make the UI clearer and to meet 80% or 90% of the users expectations. The discussions around this and the other issue shows it is not good intuitive UI

@tsteur tsteur closed this as completed Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants