New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong default date when adding annotations #5972
Comments
Well, we changed this recently because of #4888 as requested by a user and I think today makes more sense since you would usually rather add a new annotation for today than a month ago. You would otherwise always have to change the date to today |
When I click on the annotation icon for July 16th I expect to see annotations for this day and it’s correct since I can clearly see it above. So from my point of view it’s only logical that when I click “Create new annotation” and create it under this date. It makes reviewing charts easy and natural. Perhaps we should find another way to enable users to create annotation on the current day because it seems to be the problem? Current solution also fails when I have selected time range which doesn’t include current day - I don’t know if note is added or not. |
If you find another solution let me know. I think in most cases users want to create an annotation for today so it is quite important. User in #4888 assumes the same. Maybe we can display it a bit differently or position it somewhere else so that there is no reference to the selected date. Maybe we could position the "create new annotation" link above "Annotations 16 Jul 14"... There could be also too links "create annotation for today" and "create annotation for 16 Jul 14" but this is rather a workaround/hack. |
Proposed solution:
|
Could be a bit confusing for power users but could also work :) Never noticed this annotation button there before. It's very hard to notice there. Maybe could be improved as well. Maybe in this case the date picker could show two additional buttons "today" and "yesterday" when opening it to quickly select one of those values and not having to switch to the next month etc. |
+1 for @mattab "when user clicks on a given date on the calendar and click "create new annotation" then the date should be set to the clicked calendar date." +1 for @tsteur "the date picker could show two additional buttons "today" and "yesterday" when opening it" Combining these two solutions we'll make sure that average users can easily use this feature and power users can quickly change date. |
…t select the date directly and it is not possible to add another button for yesterday which are both quite annoying. When moving to Angular we better choose another calendar
…nd select the clicked date when clicking on a specific day. It still does not show today as default when clicking on annotation.
Should work. As mentioned in a previous commit the calendar today picker does not directly select the date which is annoying and the calendar component does not allow to add another button yesterday. Will close it once seeing screenshot tests. For me this solution is still only a workaround. It would be nicer to make the UI clearer and to meet 80% or 90% of the users expectations. The discussions around this and the other issue shows it is not good intuitive UI |
Problem
When I try to add new annotation on the selected day on the graph, the default date is set automatically on the current day.
It's a problem, because I have to change it manually. If I don't do it, I may not see that the annotations has been added.
Solution
When user tries to add an annotation directly on the graph, the date should automatically adjust to selected day.
The text was updated successfully, but these errors were encountered: