New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected hijacking user after clicking on sparkline and chart #5970
Comments
Tried to fix it but couldn't without putting a lot of work into a proper solution (probably days, weeks!?!) The problem is kinda in the nature of how Piwik works right now. Could be probably easily fixed once visualizations use AngularJS. The problem is the following: The first time the evolution is requested this is done with I thought about workarounds and tried different solutions but the only one that could work would be to always hardcoded replace the module/action in the URL to open with the current module/action from the URL (retrieved via |
@tsteur |
this sounds like a fine solution to always redirect the user to the currently viewed module/action - @tsteur maybe this is appropriate solution to this issue? (ie. it's better to redirect always to current module/action rather than redirect to dashboard) |
Yeah, we just have to be aware that any other behavior won't be possible anymore afterwards as it is a hack. Even for plugin developers who maybe want a different behavior as the widget could be used in many different ways... I think it would be maybe not necessarily a bug if we would always redirect to the dashboard but sometimes this and sometimes an other behavior is a bug. We can add the hack now and remove it once we rewrite the visualizations with Angular JS. |
+1 the question is whether it is better to:
I vote for 2) @tsteur does it make sense? |
yes |
… in the evolution chart, even if the metric was changed
Should work. Feel free to reopen in case of any issues |
Visitors / Overview
When I click on the sparkline in Report and then click on a point in Evolution over period chart, I'm redirected to Dashboard.
The text was updated successfully, but these errors were encountered: