Created unified system for running tests in travis for Piwik Core and any Piwik plugin. #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… any Piwik plugin. System includes a console command (generate:travis-yml) that generates a .travis.yml file for a plugin or core. The travis file will check in travis if it needs to be updated, and if so it will fail the build and tell the user. If a specific command line option is specified supplying a github user token, the .travis.yml file will be updated within travis automatically. Notes: - comments and non-travis sections will be preserved - includes logic for plugins to test themselves against latest stable version instead of just on master - the system is primarily controlled by environment variables. developers can change/add variables in .travis.yml and the auto-updating will preserve the changes.
|
@mattab Please review. |
| @@ -54,4 +54,25 @@ count=$(($count + 1)) | |||
|
|
|||
| echo -e "\n${RED}Timeout (${timeout} minutes) reached. Terminating \"$@\"${RESET}\n" | |||
| kill -9 $cmd_pid | |||
| } | |||
|
|
|||
| travis_retry() { | |||
There was a problem hiding this comment.
this function is also defined in https://github.com/piwik/piwik/blob/master/tests/angularjs/scripts/install-ubuntu.sh#L3-L22
This could be reused
|
So much automation it makes me cry with joy ;-) Looks good! |
added 4 commits
August 11, 2014 01:46
…l file is out of date]" This reverts commit 25c3bf0.
mattab
pushed a commit
that referenced
this pull request
Aug 11, 2014
Created unified system for running tests in travis for Piwik Core and any Piwik plugin.
diosmosis
pushed a commit
that referenced
this pull request
Aug 12, 2014
diosmosis
pushed a commit
that referenced
this pull request
Aug 12, 2014
…d since this is done by special GenerateTravisYml command.
diosmosis
pushed a commit
that referenced
this pull request
Aug 12, 2014
…l (directory must be the plugin dir for plugin tests).
diosmosis
pushed a commit
that referenced
this pull request
Aug 12, 2014
… autoupdating travis.yml script.
diosmosis
pushed a commit
that referenced
this pull request
Aug 12, 2014
diosmosis
pushed a commit
that referenced
this pull request
Aug 12, 2014
…date .travis.yml script. [ci skip]
diosmosis
pushed a commit
that referenced
this pull request
Aug 13, 2014
…lugins using DEPENDENT_PLUGINS travis environment variable (set in .travis.yml file manually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System includes a console command (generate:travis-yml) that generates a .travis.yml file for a plugin or core. The travis file will check in travis if it needs to be updated, and if so it will fail the build and tell the user. If a specific command line option is specified supplying a github user token, the .travis.yml file will be updated within travis automatically.
Notes:
This build is for a build w/ an out of date .travis.yml: https://travis-ci.org/piwik/piwik/builds/32146361
This build is the build that occurred right after the auto-update commit: https://travis-ci.org/piwik/piwik/builds/32146459
I will use the command on plugins after merged w/ core.