Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When there is an error in Piwik throw a http error code 500 #5958

Closed
mattab opened this issue Aug 8, 2014 · 0 comments
Closed

When there is an error in Piwik throw a http error code 500 #5958

mattab opened this issue Aug 8, 2014 · 0 comments
Assignees
@mattab
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.5.0

Comments

@mattab
Copy link
Member

mattab commented Aug 8, 2014

When there is an error in Piwik,

  • Expected: http error code 500.
  • Got: 200 code instead.

This occurs when eg. database connection fails, or when permission are not enough to write to tmp/ folder.

Question:

  • could we also write the error message via error_log function?
@mattab mattab added this to the Piwik 2.5.0 milestone Aug 8, 2014
@mattab mattab added the Task label Aug 8, 2014
mattab added a commit that referenced this issue Aug 8, 2014
@mattab
refs #5958 add http error code 500 header in case of piwik errors.
a2f3959 
Could we also add a call to error_log to log in the error.log ?
(we cannot use Log::debug or so as the logger may not be initialised yet)
@mattab mattab self-assigned this Aug 12, 2014
@mattab mattab closed this as completed in 01a76d2 Aug 13, 2014
mattab pushed a commit that referenced this issue Oct 9, 2014
Fixes #6375 refs #5958 Only set 500 headers when a database failure o…
3f6141c 
…ccurs #hacky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@mattab