5896 add showColumns/hideColumns filters to arrays #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…would work. wondering if it fails any test
…her classes which also allows plugins to define their own render formats
…ently not supposed to render anything. This should fix many tests
…with a multi dim array we should actually use the datatable renderer the php way and not the apiRenderer way
…un the filters on it will not work. Instead run the filters directly on the array. Therefore, to not have duplicated code the dataTable and row can be now treated as an array and we access them like an array in the ColumnDelete filter which will be for now the only filter is applied on arrays
…be always applied for arrays
…a subtable/expand
|
Epic Pull Request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would also allow plugins to define their own API renderers but it is not completed yet. We could do this if we want to. For instance we probably should simplify the rendering of DataTable(Map/Simple) and we would need to adjust to currently hardcoded formats in the UI to display those that are available/activated.
To make sure the API still behaves the same I ran all integration tests with all formats and compared the difference between master and this branch. Looks good!