Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run marketplace plugin tests with the defined PHP version in plugin.json #5937

Closed
tsteur opened this issue Aug 6, 2014 · 3 comments
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins.

Comments

@tsteur
Copy link
Member

tsteur commented Aug 6, 2014

When publishing a plugin on the Marketplace we automatically run tests to make sure the plugin won't break Piwik and that it works with at least PHP 5.3. A new plugin was recently published that requires at least PHP 5.4 in the plugin.json as PHP 5.4 features are used. So after publishing the plugin the build discovered an issue when using PHP 5.3:

Parse error: syntax error, unexpected '[' in /home/travis/build/piwik/piwik-tests-plugins/piwik/plugins/LdapVisitorInfo/LdapVisitorInfo.php on line <i>45</i>

see https://travis-ci.org/piwik/piwik-tests-plugins/builds/31786476

As the developer has defined that at least PHP 5.4 is required we should run the tests on PHP 5.4 and not PHP 5.3

@tsteur tsteur added this to the Short term milestone Aug 6, 2014
@tsteur tsteur added Bug labels Aug 6, 2014
@mattab
Copy link
Member

mattab commented Aug 6, 2014

Maybe it is not so easy to do as the PHP version is in the .travis.yml file which is pushed to the repository and we have no control over.

@tsteur
Copy link
Member Author

tsteur commented Aug 6, 2014

It is super easy as we generate the .travis.yml for each test using a twig template already anyway

@tsteur tsteur closed this as completed Aug 6, 2014
@mattab
Copy link
Member

mattab commented Aug 7, 2014

Looking good Thomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins.
Projects
None yet
Development

No branches or pull requests

2 participants