Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalidateArchivedReports should not delete the data but invalidate it until re-processed #5932

Closed
mattab opened this issue Aug 5, 2014 · 2 comments
Closed

invalidateArchivedReports should not delete the data but invalidate it until re-processed #5932

mattab opened this issue Aug 5, 2014 · 2 comments
Labels
c: Performance For when we could improve the performance / speed of Matomo. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.7.0

Comments

@mattab
Copy link
Member

mattab commented Aug 5, 2014

The API function CoreAdminHome.invalidateArchivedReports deletes the invalidated data.

Problem: when a lot of data is invalidated, this results in data loss in the user interface - until the reports are re-processed from the logs. It can often take hours for data to be re-processed for all dates and segments.

Goal of this ticket is to minimise temporary data loss when API invalidateArchivedReports is used by users (see How do I record tracking data in the past, and tell Piwik to re-process the past reports?)

Sub-tasks

  • make this API function invalidate the old data instead of erasing it (set a new done flag?)
  • make API read normal archives and also invalidated ones (normal ones first)
  • delete the "invalidated data" later (maybe just after the new archive was created?)
  • add test
@mattab mattab added this to the Short term milestone Aug 5, 2014
@mattab mattab mentioned this issue Aug 5, 2014
Closed
@mattab mattab modified the milestones: Short term, Piwik 2.6.0 Aug 20, 2014
@mkurzeja
Copy link
Contributor

mkurzeja commented Sep 3, 2014

Hi,

I'll be happy to work on this.

I'll commit a short proposal today

@mkurzeja mkurzeja mentioned this issue Sep 3, 2014
Merged
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 9, 2014
@mattab mattab mentioned this issue Sep 10, 2014
Open
@mattab mattab closed this as completed in 0fac10d Sep 21, 2014
@mattab mattab mentioned this issue Oct 13, 2014
Closed
@mattab mattab mentioned this issue Nov 4, 2014
Closed
@mattab
Copy link
Member Author

mattab commented Nov 5, 2014

see follow up issue in #6598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@mattab @mkurzeja