Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example Dimensions and example Reports to the ExamplePlugin #5926

Closed
mattab opened this issue Aug 4, 2014 · 3 comments
Closed

Add example Dimensions and example Reports to the ExamplePlugin #5926

mattab opened this issue Aug 4, 2014 · 3 comments
Assignees
@tsteur
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.5.0

Comments

@mattab
Copy link
Member

mattab commented Aug 4, 2014

Goals of this ticket are to:

  • re-include in Git the example Reports and Dimensions (removed in this commit)\
  • re-include this commit to restore tests: tests
  • can we disable the ExamplePlugin by default, to somehow prevent these dimensions from being added to any user unless they specifically activate ExamplePlugin plugin?
    • @tsteur noted an issue that if we disable the ExamplePlugin in an update file, it won't happen early enough during the update process and so the plugin dimensions will still be applied.

Reason the code was "removed" in the first place:

These files and tests were removed in 2.5.0 as otherwise the ExamplePlugin was creating new dimensions in log_visit, log_conversion etc. which would cause trouble to power users with large databases.

See also: #5806
@mattab mattab added this to the Piwik 2.6.0 milestone Aug 4, 2014
@mattab
Copy link
Member Author

mattab commented Aug 4, 2014

follows up #5820

@tsteur
Copy link
Member

tsteur commented Aug 5, 2014

We should imho find a solution before 2.5.0 release. I thought you want to remove it only for the first beta release. For instance Dimension and Report generator is broken now which is already documented in Getting started guides on developer.piwik.org.

@mattab
Copy link
Member Author

mattab commented Aug 5, 2014

@tsteur sounds even better before 2.5.0 but unfortunately I don't have time. Feel free to move it to 2.5.0 if you can find time for it!

tsteur added a commit that referenced this issue Aug 6, 2014
@tsteur
refs #5926 move reports to exampleReport
c434488
tsteur added a commit that referenced this issue Aug 6, 2014
@tsteur
refs #5926 added missing files
e15509d
@tsteur tsteur modified the milestones: Piwik 2.6.0, Piwik 2.5.0 Aug 6, 2014
@tsteur tsteur self-assigned this Aug 6, 2014
@tsteur tsteur closed this as completed Aug 6, 2014
tsteur added a commit that referenced this issue Aug 6, 2014
@tsteur
refs #5926 move reports to exampleReport
d882dbf
tsteur added a commit that referenced this issue Aug 6, 2014
@tsteur
refs #5926 added missing files
84c9890
tsteur added a commit that referenced this issue Aug 7, 2014
@tsteur
refs #5926 fix tests since example report is no longer enabled by def…
5c8db26 
…ault
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@tsteur @mattab