Cross-origin resource sharing #5912
Conversation
… tab and append to API headers if any is set.
|
Nice work! |
|
@czolnowski definitely, would be great to rewrite the settings in AngularJS... in the meantime, would you mind removing the new CORS settings? Instead we can add a new FAQ answer to explain to users. (it's nice to keep settings to minimum in the UI) |
|
So this settings shouldn't be available in settings, at all, yes? |
| ; Described here: http://en.wikipedia.org/wiki/Cross-origin_resource_sharing | ||
| ; | ||
| ; Examples: | ||
| ;cors_hosts[] = example.com |
There was a problem hiding this comment.
on wikipedia page I see they also use http:// in front of domains, maybe examples could have it?
👍 (because it is used only rarely so far a FAQ answer is nice way to help user to configure it) |
|
@czolnowski applied my suggested changes in: 00ab57f @halfdan I'm not sure if the comma separated notation really works. Did you test with setting two different cors_host entries? |
Add feature to persist cors hosts in config, edit in general settings tab and append to API headers if any is set.