Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When editing a SMS report, hide the row "(optional) Display options" #5904

Closed
mattab opened this issue Aug 1, 2014 · 3 comments
Closed

When editing a SMS report, hide the row "(optional) Display options" #5904

mattab opened this issue Aug 1, 2014 · 3 comments
Assignees
@tsteur
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Aug 1, 2014

The setting "(optional) Display options" should not be displayed on an SMS report edit screen. (the setting only applies to email reports)
mattab added a commit that referenced this issue Aug 1, 2014
@mattab
adding the missing class='email' refs #5904
4058135 
This still does not work unfortunately, ping @julienmoumne
@mattab mattab added the bug label Aug 1, 2014
@mattab mattab added this to the Current milestone milestone Aug 1, 2014
@tsteur tsteur self-assigned this Feb 5, 2015
@tsteur
Copy link
Member

tsteur commented Feb 5, 2015

This seems to be already done.

@tsteur tsteur closed this as completed Feb 5, 2015
@mattab
Copy link
Member Author

mattab commented Feb 6, 2015

bug still here on master (earlier commit does not fix it). the bug is that when editing a SMS report the Display options bit should be hidden eg. in:
sms optional options

@mattab mattab reopened this Feb 6, 2015
@tsteur
Copy link
Member

tsteur commented Feb 8, 2015

To make this issue more clear. It is not a problem when someone switches from Email to SMS. It is only a problem when editing an already saved entry that has the type SMS

@tsteur tsteur closed this as completed in a7002f3 Feb 8, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@tsteur @mattab