Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core piwik uses coloums in log_visit that are not available when DeviceDetector is not installed #5902

Closed
pdfforge opened this issue Aug 1, 2014 · 4 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@pdfforge
Copy link

pdfforge commented Aug 1, 2014

We have run into a problem that after our upgrade to 2.4.0, no more visits were tracked. After debugging the tracker, we saw that it failed writing into the coloumn config_os_version and we also found out, that it was introduced by the DeviceDetector, which was not installed. After activating the DeviceDetector module, the vists are tracked again.

This should be a bug though, as the coloumns should either be created by the core or not accessed when the DeviceDetector is not active.

@tsteur tsteur added this to the Piwik 2.5.0 milestone Aug 1, 2014
@tsteur tsteur added the bug label Aug 1, 2014
@tsteur
Copy link
Member

tsteur commented Aug 1, 2014

We should also test with 2.5.0-b1 (which includes a columns refactoring) whether we are running into similar issues there as columns are only installed if a plugin is activated.

@tsteur tsteur self-assigned this Aug 1, 2014
@tsteur
Copy link
Member

tsteur commented Aug 3, 2014

This should be fixed in 2.5.0 as the tracker will write only columns of enabled plugins. Did a quick check and it works when DevicesDetector is disabled. FYI: Also Live plugins still worked for me

@tsteur tsteur closed this as completed Aug 3, 2014
@tsteur tsteur added worksforme and removed bug labels Aug 3, 2014
@tsteur tsteur modified the milestones: Short term, Piwik 2.5.0 Aug 3, 2014
@larsen0815
Copy link

Why is this "not a bug" when every old installation (first install when the plugin did not yet exist) will run into "no visits being tracked"?

@tsteur
Copy link
Member

tsteur commented Aug 4, 2014

It is a bug but it was already fixed due to a refactoring in #5820

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants