Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"SegmentEditor.getAll" API should return segment "All visits" as well #5897

Closed
tsteur opened this issue Jul 30, 2014 · 2 comments
Closed

"SegmentEditor.getAll" API should return segment "All visits" as well #5897

tsteur opened this issue Jul 30, 2014 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@tsteur
Copy link
Member

tsteur commented Jul 30, 2014

I think it would be good if the mentioned API would always include the "All visits" segment a well. Otherwise in all applications you have to hard code this one. It should be probably the first segment returned in the list if possible.

@tsteur tsteur added this to the Piwik 2.5.0 milestone Jul 30, 2014
@mattab mattab removed the c: Core label Aug 3, 2014
@mattab mattab added this to the Short term milestone Aug 3, 2014
@mattab
Copy link
Member

mattab commented Aug 3, 2014

👍

@tsteur
Copy link
Member Author

tsteur commented Aug 5, 2014

Actually I think it doesn't make sense or at least it gets just more complicated if this way. Wasn't even sure when I created the issue. Makes other things more complicated such as we would have to introduce properties like "editable" etc. Also some other properties would not really make sense for the default segment so I will just close this issue.

@tsteur tsteur closed this as completed Aug 5, 2014
@tsteur tsteur added wontfix and removed Bug labels Aug 5, 2014
@tsteur tsteur self-assigned this Aug 5, 2014
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants