Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In processed report a segment parameter is not added to ImageGraph URL #5895

Closed
tsteur opened this issue Jul 30, 2014 · 1 comment
Closed

In processed report a segment parameter is not added to ImageGraph URL #5895

tsteur opened this issue Jul 30, 2014 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.5.0

Comments

@tsteur
Copy link
Member

tsteur commented Jul 30, 2014

See for instance

http://demo.piwik.org/index.php?hideMetricsDoc=1&showTimer=0&filter_limit=40&period=day&date=yesterday&idSite=7&apiModule=VisitTime&apiAction=getByDayOfWeek&showColumns=nb_visits&filter_truncate=3&sortOrderColumn=nb_visits&filter_sort_column=nb_visits&module=API&token_auth=anonymous&format=json&method=API.getProcessedReport&segment=visitCount%3E%3D5%2Cactions%3E%3D10%3BcustomVariableName3%3D%3DForum%2520status%3BcustomVariableValue3%3D%3DLoggedIn%2520user&language=en

The URL contains a segment but the segment parameter does not appear in the response:

imageGraphUrl: "index.php?module=API&method=ImageGraph.get&idSite=7&apiModule=VisitTime&apiAction=getByDayOfWeek&token_auth=anonymous&period=day&date=yesterday",

This is important for Piwik Mobile 2 see matomo-org/matomo-mobile-2#3243
@tsteur tsteur added this to the Piwik 2.5.0 milestone Jul 30, 2014
@tsteur tsteur mentioned this issue Jul 30, 2014
Closed
@mattab mattab removed the c: Core label Aug 3, 2014
@mattab mattab added this to the Piwik 2.5.0 milestone Aug 3, 2014
tsteur added a commit that referenced this issue Aug 4, 2014
@tsteur
refs #5895 should append segment parameter to imageGraph if set in th…
d32b1db 
…e original request
mattab added a commit that referenced this issue Aug 4, 2014
@mattab
refs #5895 test file now shows &segment parameter
f87e1b0
@mattab
Copy link
Member

mattab commented Aug 4, 2014

@tsteur nice fix, looks fixed so closing

@mattab mattab closed this as completed Aug 4, 2014
mattab added a commit that referenced this issue Aug 4, 2014
@mattab
refs #5895 replace _GET access by helper method
50be11d 
as a bonus it fixes the tests without having to use a Monday night's hack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@tsteur @mattab