Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cache flag #5879

Closed

Conversation

czolnowski
Copy link
Contributor

Enable option to disable clearing cache in activate and deactivate plugin.

@mattab
Copy link
Member

mattab commented Jul 24, 2014

I think that the cache should be deleted when activating/deactivating plugins as otherwise it could cause problems with out of date cache. For example some plugins modify the tracker cache, and this needs to be re-set when a plugin is disabled. and the merged assets JS/CSS must be rebuilt when a plugin is deactivated. Closing for now but we may reopen if no better solution can be found.

@mattab mattab closed this Jul 24, 2014
@czolnowski
Copy link
Contributor Author

Yes, it should be deleted after activating/deactivating. That's why default value is set to true. Purpose of this pull request is optionally disabling this action. When you run this function manually in your code.

@mattab: Did you saw my reference to this PR?

@mattab
Copy link
Member

mattab commented Jul 24, 2014

I closed the PR because it could lead to bugs: if the JS/CSS are not regenerated when a plugin is disabled for example, then the JS could reference some plugins API that is not available anymore (plugin was disabled). It would be a bug. We avoid introducing bugs :) let's discuss offline a better solution as I'm sure we will find one 👍

@czolnowski
Copy link
Contributor Author

Sounds good.

@mattab mattab added the wontfix label Aug 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants