Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download Tracking with files that contain a hash are cut off #5877

Closed
enko opened this issue Jul 23, 2014 · 3 comments
Closed

Download Tracking with files that contain a hash are cut off #5877

enko opened this issue Jul 23, 2014 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@enko
Copy link

enko commented Jul 23, 2014

Go to https://www.untergrundwelle678.de/ and click on on the download button right to the select-box with "MPEG-1 Audio Layer III". If I look in piwik GUI and there under downloads I only see this:

/sites/default/files/[UGW678

It seems that the Filename is cut off after the hash.

I'm using Piwik 2.4.1.
@enko
Copy link
Author

enko commented Jul 28, 2014

I dug a bit into this issue and I found out, that this problem must be something on the PHP-side, because the javascript tracker sends the full filename:

https://stats.datenknoten.me/piwik.php?download=https%3A%2F%2Fwww.untergrundwelle678.de%2Fsites%2Fdefault%2Ffiles%2F%5BUGW678%2353%5D%20-%20Hasitall.mp3&idsite=1&rec=1&r=372673&h=10&m=48&s=36&url=https%3A%2F%2Fwww.untergrundwelle678.de%2F&_id=0f380aef1b50bdb5&_idts=1406011769&_idvc=3&_idn=0&_refts=0&_viewts=1406114546&pdf=0&qt=0&realp=0&wma=1&dir=0&fla=0&java=1&gears=0&ag=0&cookie=1&res=1680x1050&gt_ms=263

@enko
Copy link
Author

enko commented Aug 1, 2014

Ok, I dug into the code and found out, in short that you cant log files with hashes.

Piwik uses in PageUrl::excludeQueryParametersFromUrl parse_url which is the "culprit", because it thinks that everything after the hash is a fragment, which is perfectly fine, because there is no way to know from a pure URL that this is a file.

I'll close this Ticket and will rename all the files so the downloads can be tracked.

@enko enko closed this as completed Aug 1, 2014
@mattab mattab added the wontfix label Aug 3, 2014
@mattab
Copy link
Member

mattab commented Aug 3, 2014

@enko thanks for your report and analysis of the issue.

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enko @mattab