Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisitorMap Cities view doesnt show some cities #5855

Open
ThaDafinser opened this issue Jul 18, 2014 · 5 comments
Open

VisitorMap Cities view doesnt show some cities #5855

ThaDafinser opened this issue Jul 18, 2014 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@ThaDafinser
Copy link
Contributor

The country / regions view works generally fine for me.
Also the cities view mostly works.

But some cities/coordinates are not shown.

In the first screenshot you see 16 visitors in Michigan, but in the 2nd (the cities view) they are not shown (the legend shows the correct number) . If you check the lat/long coordinates they are correct for Michigan:
https://www.google.com/maps/place/42%C2%B033'32.4%22N+83%C2%B011'24.0%22W/@42.5041012,-83.1427799,10z/data=!4m2!3m1!1s0x0:0x0

visitormap2
visitormap3
json2

@mattab mattab added the Bug label Aug 3, 2014
@mattab mattab added this to the Short term milestone Aug 3, 2014
@mattab mattab changed the title [2.4.1] VisitorMap Cities view doesnt show some citys VisitorMap Cities view doesnt show some cities Oct 12, 2014
@mattab
Copy link
Member

mattab commented Dec 1, 2014

Hi @ThaDafinser we're experiencing some bugs when User selected is set to German (which changes locale in PHP causing bugs rendering floats #6631 #6620 ). Can you reproduce this issue in German and English language?

@mattab mattab modified the milestones: Mid term, Short term Apr 7, 2015
@mattab
Copy link
Member

mattab commented Apr 8, 2015

Hi @ThaDafinser do you still have the issue in latest Piwik?

@ThaDafinser
Copy link
Contributor Author

Yes still the same problem.

@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@wingeisoftware
Copy link

I notice the same issue. Here is some additional info about this:

I believe the issue lays in kartograph. Here is a bug report in kartograph related to noverlap mode of kartograph (which the visitor map is using): kartograph/kartograph.js#47

In the attached screenshots, you can see the missing points appearing after i hacked kartograph a little bit, following instructions in kartograph issue 47. However, the "fix" used is not correct as city points are actually overlapping..

Current implementation with noverlap mode:
noverlap

"Fix" as proposed in kartograph issue 47:
hacked-kartograph

@sgiehl
Copy link
Member

sgiehl commented Apr 3, 2023

Kartograph isn't maintained anymore, so it's unlikely, that a possible fix might be provided for that library.
I'm unable to say if the "fix" might cause other problems, like overlapping points or similar.
If you are able to provide a PR that fixes it we might consider to merge it, if it doesn't cause other problems... Otherwise we hope to be able to work on #11929 at some point to fix all map related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants