Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget size issues #5852

Closed
p-banaszczyk opened this issue Jul 17, 2014 · 5 comments
Closed

Widget size issues #5852

p-banaszczyk opened this issue Jul 17, 2014 · 5 comments
Labels
answered For when a question was asked and we referred to forum or answered it. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@p-banaszczyk
Copy link

I was looking for duplicates for a while, but couldn't find anything. If this however duplicates anything, please close this issue and paste original one in comment.

There are problems with some types of widgets and reports - strictly related with columns and page/dashboard layouts. Ie.

Dashboard + page titles:
http://i.imgur.com/lKYgpNV.png

Visitors + settings
http://i.imgur.com/9fuNlr0.png

@tsteur tsteur added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 22, 2014
@tsteur
Copy link
Member

tsteur commented Jul 22, 2014

The only solution I can see so far would be to show scrollbars on the x-axis:

overflow-x: scroll;
overflow-y: hidden;

Looks ok on Mac but not so nice on Windows + Linux. One problem are the dataTableRowActions which needs to be fixed as they are positioned fixed. Would need to have a look if scrollbars would be ok for everyone. We would display them of course only if needed

@tsteur tsteur added C: Core and removed C: Core labels Jul 22, 2014
@tsteur
Copy link
Member

tsteur commented Jul 23, 2014

I tried to solve it with the scrollbars as mentioned above. The problem I couldn't fix are the dataTableRowActions as they are positioned fixed. The idea was to update the left rowActions positions on each mousemove and scroll event which works fine on Chrome but not at all on Firefox. I tried to find different solutions but couldn't. Then I tried to show the rowActions only if scrollLeft = 0 meaning hiding the rowActions if the user scrolls and showing them again if the user scrolls to the very left again. Also didn't work on Firefox since I did not always get the correct scrollLeft position. Next idea was to wrap all content within the first td in a `<div style="position:relative></div>" so we would not have to update the left value of rowActions at all but then the label of a row jumps by a few pixel on hover which I cannot explain at all. The styles are more or less the same and there was no way I could fix it.

I also tried to remove the columns that do not fit into the table but this resulted in problems with the label ellipsis (truncated too early as removing the columns before truncating results in problems and afterwards as well). It is also not that easy since we have to make sure to display at least the column the report is sorted by otherwise it would be confusing. For reports outside of the dashboard (such as Visitors => Browsers") it is not possible to see all columns since there is no "maximise" feature as it is in the dashboard.

Maybe we can have a look in Munich at this? Or maybe someone else knows a different solution? An easy fix could be to display the scrollbars and live with the fact that the tableRowActions are always fixed in the same position.

@mattab mattab removed the P: normal label Aug 3, 2014
@mattab
Copy link
Member

mattab commented Aug 3, 2014

@tsteur Thanks for reporting on your experiments. It's unlucky you couldn't find something that works nicely. Maybe someone else has an idea?

@mattab
Copy link
Member

mattab commented Oct 12, 2014

See related issue: #6159 Reponsive table which may fix this one.

@mattab mattab removed the Bug For errors / faults / flaws / inconsistencies etc. label Oct 12, 2014
@mattab mattab modified the milestones: Mid term, Short term Oct 12, 2014
@mattab mattab added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. and removed c: UI - UX (AngularJS twig less) labels Oct 12, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab
Copy link
Member

mattab commented Jun 19, 2017

this was fixed in Piwik 3

@mattab mattab closed this as completed Jun 19, 2017
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants