Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup #5847

Merged
merged 5 commits into from Jul 22, 2014
Merged

code cleanup #5847

merged 5 commits into from Jul 22, 2014

Conversation

craue
Copy link
Contributor

@craue craue commented Jul 16, 2014

Follow-up to #5813.

@craue
Copy link
Contributor Author

craue commented Jul 17, 2014

I hopefully didn't break the tests. Could you restart the timed out job?

@tsteur
Copy link
Member

tsteur commented Jul 19, 2014

Looks good! Thx a lot. Would you mind having a look at the message of this exception: https://github.com/piwik/piwik/blob/master/plugins/CoreConsole/Commands/GenerateVisualizationPlugin.php#L75

When updating this message we should be able to automatically merge.

@craue
Copy link
Contributor Author

craue commented Jul 19, 2014

Sure, rebased.

tsteur added a commit that referenced this pull request Jul 22, 2014
@tsteur
Merge pull request #5847 from craue/code-cleanup-2
ba70cfb 
code cleanup
@tsteur tsteur merged commit ba70cfb into matomo-org:master Jul 22, 2014
@tsteur
Copy link
Member

tsteur commented Jul 22, 2014

Thx!

@tsteur tsteur added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@craue @tsteur