Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong variable usage #5835

Closed
wants to merge 1 commit into from

Conversation

craue
Copy link
Contributor

@craue craue commented Jul 15, 2014

Separated from #5813.

@craue craue mentioned this pull request Jul 15, 2014
@tsteur
Copy link
Member

tsteur commented Jul 22, 2014

Thx @craue ! I had a look at the code and probably the reason why nobody noticed it is the third parameter is not used in getGenericFiltersInformation(). It would probably make more sense to just remove those lines and use $name again: https://github.com/piwik/piwik/blob/master/core/API/DataTableGenericFilter.php#L151-L156

Would you mind doing that? That'd be great!

@tsteur tsteur added the C: Core label Jul 22, 2014
@craue craue mentioned this pull request Jul 22, 2014
@craue craue closed this Jul 22, 2014
@craue
Copy link
Contributor Author

craue commented Jul 22, 2014

Alright, @tsteur.

@mattab mattab added the Task label Aug 3, 2014
@mattab mattab added this to the Piwik 2.5.0 milestone Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants