Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with changing segment name. #5816

Closed
MichalTomczak opened this issue Jul 11, 2014 · 4 comments
Closed

Issues with changing segment name. #5816

MichalTomczak opened this issue Jul 11, 2014 · 4 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@MichalTomczak
Copy link

Steps to reproduce:

  1. open segment and choose one to edit
  2. click “edit” next to a segment name
  3. type in new name and click on “save and apply”
  4. the text box will close and new name will be visible
  5. click outside of the segment to close the segment drop-down
  6. the name will change back.

To correctly rename a segment:

after typing new name

  1. click somewhere outside of the text box but inside the segment drop-down, to close the text box.
  2. Now click “save and apply”
  3. the drop-down will close automatically and the new name will stay

this is quite confusing

@tsteur
Copy link
Member

tsteur commented Jul 19, 2014

I think the behavior is actually expected. Otherwise you would assume the new segment name is already saved/persisted when clicking outside the segment box which is not the case. The new segment name will be saved only after pressing "save and apply". The moment you click outside the box is more or less the same action as "close" / "cancel".

@RMastop
Copy link
Contributor

RMastop commented Jul 19, 2014

The issue is actually that the segment name is not changing after changing
the name and clicking the save button directly. You have to click outside
of the edit field before clicking the save button.
Op 19 jul. 2014 12:44 schreef "Thomas Steur" notifications@github.com:

I think the behavior is actually expected. Otherwise you would assume the
new segment name is already saved/persisted when clicking outside the
segment box which is not the case. The new segment name will be saved only
after pressing "save and apply". The moment you click outside the box is
more or less the same action as "close" / "cancel".


Reply to this email directly or view it on GitHub
#5816 (comment).

@tsteur
Copy link
Member

tsteur commented Jul 21, 2014

True, I'll have a look

@tsteur
Copy link
Member

tsteur commented Jul 21, 2014

Actually, you don't have to click outside before clicking the save button. This is not very intuitive though. It indicates you have to click outside to save the name and it also indicates it will be saved directly. I am going to change this... Once you enabled the input text field for changing the segment name after pressing 'edit' it will no longer go away unless you press "save". If you click outside the segment editor it will reset to the original name and no longer show the input text field as it does currently already (same for pressing "close").

tsteur added a commit that referenced this issue Jul 21, 2014
…there until user presses save button for better UX. @MichalTomczak is this ok for you?
@tsteur tsteur added the C: Core label Jul 21, 2014
@tsteur tsteur added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 21, 2014
@tsteur tsteur self-assigned this Jul 21, 2014
@tsteur tsteur closed this as completed Jul 21, 2014
@mattab mattab added the Bug label Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants