There are cases when an upgrade can fail, for example: when an upgrade adds a column to a table and an existing column with the same name already exists in that table. In this case there is possibility to ignore the error by setting in the getSql() a value eg. 1060, such as this example: 1.12-b16 upgrade

Goal of this ticket is to ensure that we force Piwik developers to always set a correct error code for each SQL query. This will ensure that when Piwik admins run the upgrade several times, then the upgrade will always succeed.

Proposal

• maybe we throw an exception whenever a SQL query does not have an error code set? (eg. when => false in getSql). This exception will be seen by Piwik developer when he tests his upgrade file. Or if developer does not test his code (bad) then it should at least show in the Upgrade 1.0 -> latest version UI test (source)
• we need to update existing upgrade files to make sure that all SQL queries have the proper error code set