New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add namespaces to test files #5800
Comments
…add IntegrationTestCase to a namespace, re-add individual test @groups, move test groups to class level, and rename test files & class names so underscores are not used.
@diosmosis maybe this can be closed? |
I forgot to mention it here but I added namespace for all unit tests last week: 5651dd9 As @diosmosis said there is still some work to do, most other tests are not in a namespace. |
@mnapoli what work is left for this issue? it would be nice to close it in next release if not too much work involved! |
I just notice now there is the "major" tag, I don't think it's major right? And there is no rush regarding releases, this is just namespacing the tests, it's like continuous background quality improvement. I don't think there is any user impact. The work left is that some tests are not in a namespace. |
I put |
Done what's left in 8ed874f |
Nice @mnapoli ! are all tests in Piwik core + Piwik org plugins are using namespaces? |
I haven't had a look at all the external plugins. I had also an overview (i.e. maybe 20%) of all internal plugins and all the one I've seem are namespaced, so even if we have a few left behind it's OK, we can fix them when we find them. |
This issue is for all work relating to adding namespaces to test files.
base namespace: Piwik\Tests
fixtures: Piwik\Tests\Fixtures
integration tests: Piwik\Tests\Integration
core tests: Piwik\Tests\Core
plugin tests: move to plugin (use Integration phpunit group)
The text was updated successfully, but these errors were encountered: