Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespaces to test files #5800

Closed
diosmosis opened this issue Jul 9, 2014 · 9 comments
Closed

add namespaces to test files #5800

diosmosis opened this issue Jul 9, 2014 · 9 comments
Assignees
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@diosmosis
Copy link
Member

This issue is for all work relating to adding namespaces to test files.

base namespace: Piwik\Tests
fixtures: Piwik\Tests\Fixtures
integration tests: Piwik\Tests\Integration
core tests: Piwik\Tests\Core
plugin tests: move to plugin (use Integration phpunit group)

@diosmosis diosmosis self-assigned this Jul 9, 2014
diosmosis pushed a commit that referenced this issue Jul 9, 2014
…add IntegrationTestCase to a namespace, re-add individual test @groups, move test groups to class level, and rename test files & class names so underscores are not used.
@mattab mattab added this to the Piwik 2.5.0 milestone Aug 3, 2014
@mattab mattab added the Task label Aug 3, 2014
@mattab mattab modified the milestones: Piwik 2.5.0, Mid term, Short term Aug 3, 2014
@mattab
Copy link
Member

mattab commented Oct 10, 2014

@diosmosis maybe this can be closed?

@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Oct 10, 2014
@diosmosis
Copy link
Member Author

@mattab No, I think most tests are still not in a namespace. Now that @tsteur refactored the folder structure though, it might be easier to add namespaces.

@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Oct 13, 2014
@mnapoli
Copy link
Contributor

mnapoli commented Nov 10, 2014

I forgot to mention it here but I added namespace for all unit tests last week: 5651dd9

As @diosmosis said there is still some work to do, most other tests are not in a namespace.

@mattab
Copy link
Member

mattab commented Nov 10, 2014

@mnapoli what work is left for this issue? it would be nice to close it in next release if not too much work involved!

@mnapoli
Copy link
Contributor

mnapoli commented Nov 10, 2014

I just notice now there is the "major" tag, I don't think it's major right? And there is no rush regarding releases, this is just namespacing the tests, it's like continuous background quality improvement. I don't think there is any user impact.

The work left is that some tests are not in a namespace.

@mattab
Copy link
Member

mattab commented Nov 11, 2014

I put Major tag as it's important to be consistent + it makes things easier for developers looking into adding tests when all existing tests look the same.

@mnapoli
Copy link
Contributor

mnapoli commented Nov 14, 2014

Done what's left in 8ed874f

@mnapoli mnapoli closed this as completed Nov 14, 2014
@mnapoli mnapoli modified the milestones: Piwik 2.10.0 , Short term Nov 14, 2014
@mattab
Copy link
Member

mattab commented Nov 14, 2014

Nice @mnapoli !

are all tests in Piwik core + Piwik org plugins are using namespaces?
is it also the case for premium plugins or not yet maybe?

@mnapoli
Copy link
Contributor

mnapoli commented Nov 14, 2014

I haven't had a look at all the external plugins. I had also an overview (i.e. maybe 20%) of all internal plugins and all the one I've seem are namespaced, so even if we have a few left behind it's OK, we can fix them when we find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants