Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Non-static method Piwik_Visualization_OpenFlashChart::esc() should not be called statically, assuming $this from incompatible context" #5718

Closed
anonymous-matomo-user opened this issue Jul 10, 2008 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@anonymous-matomo-user
Copy link

On each request to the Dashboard I get several of the following errors:

“Non-static method Piwik_Visualization_OpenFlashChart::esc() should not be called statically, assuming $this from incompatible context”

The errors occur from the calls on lines 1277, 1289, 1295, 1301, 1302, 1427, 1439, and 1445.

The issue is that Piwik_Visualization_OpenFlashChart::esc() is an instance method even though it does not use or affect any instance state. As such, it should be a static method.

I’ve attached a patch that makes the method static and thus prevents all the error messages.

I understand that this is really an issue with OpenFlashChart, and am going to submit it there as well. However, I think it should be fixed here in the meantime so that the log files do not fill up with unnecessary noise.

@anonymous-matomo-user
Copy link
Author

Attachment:
[make_esc_static.diff](http://issues.piwik.org/attachments/5718/make_esc_static.diff)

@mattab
Copy link
Member

mattab commented Jul 21, 2008

thanks for reporting, fixed in 566

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants