Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users with "view" access should see the link to display the javascript code for their sites #554

Closed
mattab opened this issue Feb 12, 2009 · 9 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.

Comments

@mattab
Copy link
Member

mattab commented Feb 12, 2009

Users with a “view” permission should see the table with the website information and the “Show Javascript” link, the same way “admin” users currently see the table.

For users with “view”, the website table wouldn’t be editable.

see also #526

@robocoder
Copy link
Contributor

Moving this to 0.6. Access to #42 ("exclude visits by cookie") should be incorporated into the SitesManager UI.

@anonymous-matomo-user
Copy link

I extended the MultiSites-Controller table by a new Icon, linked to the javascript code of the site.
For displaying the javascrit code, i utilize the existing SitesManager module. For non-Admin user i disable the SitesManager-Navigation.
See attached Screenshot and patch.

Would this an adequate solution for this ticket?

@anonymous-matomo-user
Copy link

Attachment:
patch#554.txt

@anonymous-matomo-user
Copy link

Attachment: Icon
js.gif

@anonymous-matomo-user
Copy link

Attachment:
MultiSite-extended.png

@mattab
Copy link
Member Author

mattab commented Apr 8, 2010

Sophie,
I think it would be better to have the javascript displayed in the "website" tab for "view" users, after clicking "settings" in the top bar (available in trunk for "view" users)

@anonymous-matomo-user
Copy link

Ok, i see.

So it's changing #526:
"- for user with 'view', only show the "My Profile" tab"
to
"- for user with 'view', show the "My Profile" and "Websites" tab".
Right?

There are two further questions for me:

For the view-only user the table's content it's clear: "For users with "view", the website table wouldn't be editable."
But I can't find anything about the editing by an admin user. Currently it's behaving strange (Edit is clickable, just site name is changeable, but changes can't be saved).
How should the table editing/deleting behave for an admin user?

I assume: For multi sites a user can have view access to one site as well as admin access to another site. Am i right?
If yes: Should view and admin sites mixed into one table? Or do you like to provide seperate tables? Shurely it depends whether the interaction of view and admin user will be different or not. If not, the sites could simply shown in one table.

@mattab
Copy link
Member Author

mattab commented Apr 29, 2010

I think that it could be like:

  • view users "Websites" tab shows the table of websites, with rows that are not editable
  • admin users' "Websites" tab is the same behavior as current Websites tab (editable website table).

If the edit website screen does not work for you, it is a bug in Piwik. It works for us in 0.5.5 and 0.6-rc1 (edit name / URLs / etc. and click the green button to update).

There is no difference in how view or admin websites are handled in all the web analytics reports: they behave exactly the same.

@mattab
Copy link
Member Author

mattab commented Jan 13, 2014

Currently as of Piwik 2.0 the Tracking Code page is listed when the user has at least Admin permission to one website. Seems right.

@mattab mattab added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants