You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mattab opened this issue
Feb 11, 2008
· 6 comments
Labels
MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.TaskIndicates an issue is neither a feature nor a bug and it's purely a "technical" change.
(In [[mauser](447]))- refs #5482 commited huge work by Maciej Zawadzi?\197?\132ski: thanks! still some work to do + QA but looks really good :)
[mauser]- refs #5536 commited partial fix
[mauser]- refs #5485 commited partial fix
- fixed broken tests
feedback:
- similar to #65 we should test to make sure the email is sent.
In this case, if the email cannot be sent for some reasons, we should show the message the user just typed and ask him to manually email us at hello@..
- the styles seem not defined, the input boxes are larger than the modal on my FF?
- I suggest we have only the fields: Your email, Message. All these extra fields are a bit overkill in this case.
- remove the “or esc Key” text
- change the close text with an icon (for example http://www.iconfinder.net/iconlib/bnw/16×16/actions/stop.png)
- make sure the font is georgia to be consisten with the rest of piwik
- good job! :)
(In [[mauser](454])) – fixes #5536, font consistent, escape key now works
[mauser] – fixes #5485, now catching error, printing friendly message, refactoring template code
[mauser] – fixes #5482, fixing JS translations api, Piwik is now ready to be translated!!! :)
MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.TaskIndicates an issue is neither a feature nor a bug and it's purely a "technical" change.
See an example (second example) on http://www.ericmmartin.com/simplemodal/
The text was updated successfully, but these errors were encountered: