Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feeback modal window in the user interface to send an email to the piwik team #5536

Closed
mattab opened this issue Feb 11, 2008 · 6 comments
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@mattab
Copy link
Member

mattab commented Feb 11, 2008

See an example (second example) on http://www.ericmmartin.com/simplemodal/

@zawadzinski
Copy link
Contributor

Working on this.

Apart from modal I will add a Piwik_Mailer class which is missing (I need it to solve #65 too).

@mattab
Copy link
Member Author

mattab commented Apr 17, 2008

(In [[mauser](447]))- refs #5482 commited huge work by Maciej Zawadzi?\197?\132ski: thanks! still some work to do + QA but looks really good :)
[mauser]- refs #5536 commited partial fix
[mauser]- refs #5485 commited partial fix
- fixed broken tests

@mattab
Copy link
Member Author

mattab commented Apr 17, 2008

feedback:
- similar to #65 we should test to make sure the email is sent.
In this case, if the email cannot be sent for some reasons, we should show the message the user just typed and ask him to manually email us at hello@..
- the styles seem not defined, the input boxes are larger than the modal on my FF?
- I suggest we have only the fields: Your email, Message. All these extra fields are a bit overkill in this case.
- remove the “or esc Key” text
- change the close text with an icon (for example http://www.iconfinder.net/iconlib/bnw/16×16/actions/stop.png)
- make sure the font is georgia to be consisten with the rest of piwik
- good job! :)

@zawadzinski
Copy link
Contributor

Attachment:
[feedback.patch](http://issues.piwik.org/attachments/5536/feedback.patch)

@zawadzinski
Copy link
Contributor

- close icon
- check if email was sent
- defined styles

@mattab
Copy link
Member Author

mattab commented Apr 24, 2008

(In [[mauser](454])) – fixes #5536, font consistent, escape key now works
[mauser] – fixes #5485, now catching error, printing friendly message, refactoring template code
[mauser] – fixes #5482, fixing JS translations api, Piwik is now ready to be translated!!! :)

@mattab mattab added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants