Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost your password? module #5485

Closed
mattab opened this issue Jan 4, 2008 · 6 comments
Closed

Lost your password? module #5485

mattab opened this issue Jan 4, 2008 · 6 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 4, 2008

When user lost their password they should have the ability to receive it by email.

@zawadzinski
Copy link
Contributor

Working on this.

@mattab
Copy link
Member Author

mattab commented Apr 17, 2008

(In [[mauser](447]))- refs #5482 commited huge work by Maciej Zawadzi?\197?\132ski: thanks! still some work to do + QA but looks really good :)
[mauser]- refs #5536 commited partial fix
[mauser]- refs #5485 commited partial fix
- fixed broken tests

@mattab
Copy link
Member Author

mattab commented Apr 17, 2008

feedback:
- I think you didn’t test the code when input the email, i fixed a bug there
- An exception is thrown on my box:

``

`
Warning: mail() [function.mail]: “sendmail_from” not set in php.ini or custom “From:” header missing in F:\piwik\svn-dev\trunk\libs\Zend\Mail\Transport\Sendmail.php on line 91
need to check for that and if it doesn’t work then point the user to a FAQ that explains how to change the password manually

  • there is copied pasted code in the templates, it should be refactored so that all Login templates use the same structure (we should never reuse code when refactoring is possible)
  • good job :)
    ``````

@zawadzinski
Copy link
Contributor

Attachment:
[lostpassword.patch](http://issues.piwik.org/attachments/5485/lostpassword.patch)

@zawadzinski
Copy link
Contributor

- check if email was sent
- code is no longer duplicated in templaes

@mattab
Copy link
Member Author

mattab commented Apr 24, 2008

(In [[mauser](454])) – fixes #5536, font consistent, escape key now works
[mauser] – fixes #5485, now catching error, printing friendly message, refactoring template code
[mauser] – fixes #5482, fixing JS translations api, Piwik is now ready to be translated!!! :)

@mattab mattab added this to the Piwik 0.9.9 - Stable release milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants