Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client detection #5413

Open
sgiehl opened this issue Jul 4, 2014 · 12 comments
Open

Client detection #5413

sgiehl opened this issue Jul 4, 2014 · 12 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
Backlog (Help wan...

Comments

@sgiehl
Copy link
Member

sgiehl commented Jul 4, 2014

Currently Piwik is only able to detect browsers.
Instead of detecting only browsers we should open up piwik to client based detection.
Clients can be browsers, as well as media players, mobile apps, personal information managers (like mail clients), feed readers and so on.
The DeviceDetector used by Piwik is already able to detect such clients.
As it is impossible to define short codes for all those possible clients, we might need to move away from only saving short codes (like it is actually done for browsers)

With client based detection there will be more reports possible within Piwik. So it would be nice to see which client types mostly visits a website and os on.
@sgiehl sgiehl added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
@ThaDafinser
Copy link
Contributor

@sgiehl i would go further...save all client $_SERVER vars serialized in one field inside piwik_log_visit.
Pro:

  • at an upgrade you can extract them, if other table fields need to be field
  • you can update the short codes or other things at an upgrade

Con:

  • possible overflow (TEXT can be too small....i had it one time as LARGETEXT....)
  • needs a lot of space

@mattab mattab removed the c: Core label Aug 3, 2014
@mattab mattab added this to the Short term milestone Aug 3, 2014
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 9, 2014
@sgiehl sgiehl mentioned this issue Nov 3, 2014
Closed
@sgiehl sgiehl mentioned this issue Feb 21, 2015
Closed
@mattab
Copy link
Member

mattab commented Apr 7, 2015

Hi @sgiehl - great idea of a new report for Piwik.

Do you maybe have some idea on approx estimate for this issue?

@sgiehl
Copy link
Member Author

sgiehl commented Apr 7, 2015

I think that would take a few days for implementation. We need to built a switch between the different client types and therefor adjust the table structure as we need additional information. Currently all client types other than browser will be reported as "unknown" browser, which will then be excluded from the browser reports. Maybe I can provide a detailed list of todos as soon as I have some time for that.

I would love to see that in the near future!

@mattab mattab modified the milestones: Mid term, Short term Apr 7, 2015
@sgiehl sgiehl mentioned this issue May 17, 2015
Closed
@mattab mattab added duplicate For issues that already existed in our issue tracker and were reported previously. and removed Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Dec 5, 2016
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab mattab removed the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 5, 2016
@sgiehl sgiehl mentioned this issue Jan 21, 2017
Closed
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Feb 28, 2017
@sgiehl sgiehl mentioned this issue May 17, 2017
Closed
@bigretromike
Copy link

is near feature now 👍 ?

@Findus23 Findus23 mentioned this issue May 7, 2019
Closed
@bigretromike
Copy link

Hello, is there way to help with this ? Maybe sort all ShortCodes for all type of devices ?

@sgiehl
Copy link
Member Author

sgiehl commented May 7, 2019

that might require various database changes to be able to store other client types than browsers. Guess such a change won't be doable before the next major release.

@bigretromike
Copy link

bigretromike commented May 7, 2019 via email

@bigretromike
Copy link

Looking thru gh I found: #13929 looks like you started moving from codes to names.
So could I assume the future is closer than it was year ago ?:-)

@mattab
Copy link
Member

mattab commented Aug 7, 2019

Would it work to simply use different shortcodes for the new clients we want to detect?

@bigretromike
Copy link

@mattab I does exactly that! But I understand that the issue was that Matomo store '2 char value' and that would go out of stock if used that way for every client.
But as I remember moving from shortcodes to names was one of requirements to add a custom client detection without needing to edit manually detection library to detect other kinds of devices that are not browsers but yet are able to access pages and are excludes from browser raport (ex. media players)

@sgiehl
Copy link
Member Author

sgiehl commented Aug 7, 2019

exactly. device detector is for example able to detect names of mobile apps. that can't be be combined with short codes in any way

@bigretromike
Copy link

that why you need currently overwrite detect library to include those in browser and exclude them from ex. mobile apps - then you are able to measure real traffic and how does it come to you.
And I have fingers cross that we be able to add our 'browsers' or change some settings to include those 'apps/applications/programs' that access our content thru web

@sgiehl sgiehl mentioned this issue Aug 20, 2019
Closed
@sgiehl sgiehl mentioned this issue Jan 31, 2020
Closed
@sgiehl sgiehl mentioned this issue Jun 8, 2020
Open
@sgiehl sgiehl mentioned this issue Jul 9, 2020
Merged
@Starker3 Starker3 mentioned this issue Mar 22, 2021
Open
@sgiehl sgiehl mentioned this issue Mar 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
4 participants
@mattab @ThaDafinser @sgiehl @bigretromike