Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transitions on Page Titles regressed in 2.4.0 #5411

Closed
mattab opened this issue Jul 4, 2014 · 2 comments
Closed

Transitions on Page Titles regressed in 2.4.0 #5411

mattab opened this issue Jul 4, 2014 · 2 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone
2.5.0

Comments

@mattab
Copy link
Member

mattab commented Jul 4, 2014

Regression from the hack introduced in #4363

we forgot to implement the change discussed in #4363

This was reported in the forums.
@mattab
Copy link
Member Author

mattab commented Jul 4, 2014

  • Add Screenshot test for transition on Page Title
    • Such test will help us detect such regression in the future

@diosmosis
Copy link
Member

In bcf5595: Fixes #5411, refs #4363 use '%20' to differentiate between terminal + leaf rows in row evolution JS instead of '+' since JS urlDecodeComponent does not decode + chars.

@mattab mattab added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
diosmosis pushed a commit that referenced this issue Jul 9, 2014
Fixes #5411, refs #4363 use '%20' to differentiate between terminal +…
bcf5595 
… leaf rows in row evolution JS instead of '+' since JS urlDecodeComponent does not decode + chars.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@diosmosis @mattab